* [PATCH] spi/spidev: Convert to use unified device property API
@ 2014-12-29 9:41 Mika Westerberg
2014-12-29 16:03 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Mika Westerberg @ 2014-12-29 9:41 UTC (permalink / raw)
To: linux-spi
Cc: Mark Brown, Grant Likely, Rob Herring, Rafael J. Wysocki,
Mika Westerberg, linux-kernel
This will allow the driver to match using DT compatible property if the
device has ACPI _HID of "PRP0001" and accompanying "compatible" property
listed in _DSD.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/spi/spidev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 6941e04afb8c..f4742fad4307 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -700,7 +700,7 @@ static struct spi_driver spidev_spi_driver = {
.driver = {
.name = "spidev",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(spidev_dt_ids),
+ .of_match_table = spidev_dt_ids,
},
.probe = spidev_probe,
.remove = spidev_remove,
--
2.1.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] spi/spidev: Convert to use unified device property API
2014-12-29 9:41 [PATCH] spi/spidev: Convert to use unified device property API Mika Westerberg
@ 2014-12-29 16:03 ` Mark Brown
2014-12-30 7:37 ` Mika Westerberg
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2014-12-29 16:03 UTC (permalink / raw)
To: Mika Westerberg
Cc: linux-spi, Grant Likely, Rob Herring, Rafael J. Wysocki,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On Mon, Dec 29, 2014 at 11:41:14AM +0200, Mika Westerberg wrote:
> This will allow the driver to match using DT compatible property if the
> device has ACPI _HID of "PRP0001" and accompanying "compatible" property
> listed in _DSD.
Which nobody should be doing since it's already totally broken for
something to be using this on the DT side except in the one case of the
Rohm device which is listed there. I don't want to merge anything which
allows the breakage we're seeing with people putting spidev in their DTs
to be propagated into ACPI, at most we should have something that
specifically identifies individual devices only.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spi/spidev: Convert to use unified device property API
2014-12-29 16:03 ` Mark Brown
@ 2014-12-30 7:37 ` Mika Westerberg
2014-12-30 11:23 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Mika Westerberg @ 2014-12-30 7:37 UTC (permalink / raw)
To: Mark Brown
Cc: linux-spi, Grant Likely, Rob Herring, Rafael J. Wysocki,
linux-kernel
On Mon, Dec 29, 2014 at 04:03:16PM +0000, Mark Brown wrote:
> On Mon, Dec 29, 2014 at 11:41:14AM +0200, Mika Westerberg wrote:
> > This will allow the driver to match using DT compatible property if the
> > device has ACPI _HID of "PRP0001" and accompanying "compatible" property
> > listed in _DSD.
>
> Which nobody should be doing since it's already totally broken for
> something to be using this on the DT side except in the one case of the
> Rohm device which is listed there. I don't want to merge anything which
> allows the breakage we're seeing with people putting spidev in their DTs
> to be propagated into ACPI, at most we should have something that
> specifically identifies individual devices only.
It is pretty convenient for testing SPI bus and that's why I thought
it would be good to have possibility to enumerate this in similar way
than DT does but I understand your point.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spi/spidev: Convert to use unified device property API
2014-12-30 7:37 ` Mika Westerberg
@ 2014-12-30 11:23 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-12-30 11:23 UTC (permalink / raw)
To: Mika Westerberg
Cc: linux-spi, Grant Likely, Rob Herring, Rafael J. Wysocki,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On Tue, Dec 30, 2014 at 09:37:14AM +0200, Mika Westerberg wrote:
> On Mon, Dec 29, 2014 at 04:03:16PM +0000, Mark Brown wrote:
> > Which nobody should be doing since it's already totally broken for
> > something to be using this on the DT side except in the one case of the
> > Rohm device which is listed there. I don't want to merge anything which
> > allows the breakage we're seeing with people putting spidev in their DTs
> > to be propagated into ACPI, at most we should have something that
> > specifically identifies individual devices only.
> It is pretty convenient for testing SPI bus and that's why I thought
> it would be good to have possibility to enumerate this in similar way
> than DT does but I understand your point.
My intention is to break this for DT, at least make it scream loud
warnings when it's used if not actually fail.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-30 11:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-29 9:41 [PATCH] spi/spidev: Convert to use unified device property API Mika Westerberg
2014-12-29 16:03 ` Mark Brown
2014-12-30 7:37 ` Mika Westerberg
2014-12-30 11:23 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox