From: "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>
To: Ken Xue <Ken.Xue@amd.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] acpi:apd:add AMD ACPI2Platform device support for x86 system.
Date: Tue, 3 Feb 2015 12:15:33 +0200 [thread overview]
Message-ID: <20150203101533.GH1465@lahna.fi.intel.com> (raw)
In-Reply-To: <1422957325.18208.13.camel@kxue-X58A-UD3R>
On Tue, Feb 03, 2015 at 05:55:25PM +0800, Ken Xue wrote:
> On Tue, 2015-02-03 at 11:53 +0200, mika.westerberg@linux.intel.com
> wrote:
> > On Tue, Feb 03, 2015 at 09:04:55AM +0800, Ken Xue wrote:
> > > as you said, platform_drv_probe calls dev_pm_domain_attach(). but
> > > platform_drv_probe just is a default probe routine. Not all platform
> > > device drivers use this probe routine. so, codes here may be still
> > > necessary.
> >
> > Are you saying that for platform devices there is some other path to get
> > a driver probed, other than platform_drv_probe()? Can you point me to
> > it?
> >From the codes, i can see there is a possibility that drv->driver.probe
> may not be set in __platform_driver_register. But i really can not point
> out a use case that platform device driver without probe.
> so, it is safe to remove "dev_pm_domain_attach" in
> "acpi_apd_platform_notify". right?
In that case, I think so, yes.
prev parent reply other threads:[~2015-02-03 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 9:50 [PATCH V2] acpi:apd:add AMD ACPI2Platform device support for x86 system Ken Xue
2015-02-02 13:03 ` mika.westerberg
2015-02-03 1:04 ` Ken Xue
2015-02-03 9:53 ` mika.westerberg
2015-02-03 9:55 ` Ken Xue
2015-02-03 10:15 ` mika.westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150203101533.GH1465@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Ken.Xue@amd.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox