From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tal Shorer <tal.shorer@gmail.com>
Cc: "Drokin, Oleg" <oleg.drokin@intel.com>,
"<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
"Dilger, Andreas" <andreas.dilger@intel.com>,
"<gregkh@linuxfoundation.org>" <gregkh@linuxfoundation.org>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
"<clabbe.montjoie@gmail.com>" <clabbe.montjoie@gmail.com>,
"<PDD-discuss@lists.01.org>" <PDD-discuss@ml01.01.org>
Subject: Re: [PATCH v2] staging: lustre: fix coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
Date: Mon, 9 Feb 2015 10:31:45 +0300 [thread overview]
Message-ID: <20150209073145.GD5206@mwanda> (raw)
In-Reply-To: <CAFDyS3MvO3Wrk3QX6__vWnWf6y+dJZEXdG9ke=HfEmLjSa8Kvw@mail.gmail.com>
On Sun, Feb 08, 2015 at 07:57:01PM +0200, Tal Shorer wrote:
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
> Decided not to #define the constants away because their addresses are
> used later in the file.
I don't understand what this means.
>
1) The subject is crap (which coding style issues are you fixing).
2) The subject is too long.
3) Don't put the whole path in the subject.
4) There is no patch description.
regards,
dan carpenter
prev parent reply other threads:[~2015-02-09 7:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-08 17:57 [PATCH v2] staging: lustre: fix coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c Tal Shorer
2015-02-09 7:31 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209073145.GD5206@mwanda \
--to=dan.carpenter@oracle.com \
--cc=PDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=clabbe.montjoie@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=tal.shorer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox