* [PATCH v2] staging: lustre: fix coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
@ 2015-02-08 17:57 Tal Shorer
2015-02-09 7:31 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Tal Shorer @ 2015-02-08 17:57 UTC (permalink / raw)
To: Drokin, Oleg
Cc: <linux-kernel@vger.kernel.org>, Dilger, Andreas,
<gregkh@linuxfoundation.org>,
<dan.carpenter@oracle.com>, <luca@lucaceresoli.net>,
<clabbe.montjoie@gmail.com>,
<PDD-discuss@lists.01.org>,
<devel@driverdev.osuosl.org>
Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
Decided not to #define the constants away because their addresses are
used later in the file.
drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
index c539e37..acc2e10 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
@@ -65,7 +65,7 @@
#include <asm/div64.h>
#include "../tracefile.h"
-static struct ctl_table_header *lnet_table_header = NULL;
+static struct ctl_table_header *lnet_table_header;
extern char lnet_upcall[1024];
/**
* The path of debug log dump upcall script.
@@ -308,7 +308,7 @@ static int proc_console_backoff(struct ctl_table
*table, int write,
dummy.proc_handler = &proc_dointvec;
if (!write) { /* read */
- backoff= libcfs_console_backoff;
+ backoff = libcfs_console_backoff;
rc = proc_dointvec(&dummy, write, buffer, lenp, ppos);
return rc;
}
--
2.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] staging: lustre: fix coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
2015-02-08 17:57 [PATCH v2] staging: lustre: fix coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c Tal Shorer
@ 2015-02-09 7:31 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2015-02-09 7:31 UTC (permalink / raw)
To: Tal Shorer
Cc: Drokin, Oleg, <devel@driverdev.osuosl.org>, Dilger, Andreas,
<gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>,
<clabbe.montjoie@gmail.com>,
<PDD-discuss@lists.01.org>
On Sun, Feb 08, 2015 at 07:57:01PM +0200, Tal Shorer wrote:
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
> Decided not to #define the constants away because their addresses are
> used later in the file.
I don't understand what this means.
>
1) The subject is crap (which coding style issues are you fixing).
2) The subject is too long.
3) Don't put the whole path in the subject.
4) There is no patch description.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-09 7:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08 17:57 [PATCH v2] staging: lustre: fix coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c Tal Shorer
2015-02-09 7:31 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox