From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Tolga Ceylan <tolga.ceylan@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Staging: iio: meter: ade7854-i2c: code style improvements
Date: Fri, 13 Feb 2015 13:57:20 +0530 [thread overview]
Message-ID: <20150213082720.GA6088@sudip-PC> (raw)
In-Reply-To: <1423810186-28774-1-git-send-email-tolga.ceylan@gmail.com>
On Thu, Feb 12, 2015 at 10:49:46PM -0800, Tolga Ceylan wrote:
> Code reformatting based on checkpatch.pl with --strict:
> 1) Lines over 80 characters were fixed
> 2) Alignment should match open paranthesis cases corrected
> 3) Comparison to NULL rewritten as !indio_dev
you are doing three different types of changes here. one patch should have only one type of change.
regards
sudip
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
> ---
> drivers/staging/iio/meter/ade7854-i2c.c | 39 +++++++++++++++++----------------
> 1 file changed, 20 insertions(+), 19 deletions(-)
>
>
next prev parent reply other threads:[~2015-02-13 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 6:49 [PATCH 1/1] Staging: iio: meter: ade7854-i2c: code style improvements Tolga Ceylan
2015-02-13 8:27 ` Sudip Mukherjee [this message]
2015-02-13 22:05 ` Tolga Ceylan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150213082720.GA6088@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tolga.ceylan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox