From: Borislav Petkov <bp@alien8.de>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Oleg Nesterov <oleg@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Alexei Starovoitov <ast@plumgrid.com>,
Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] x86: entry.S: use JZ mnemonic after TEST, not JE
Date: Thu, 26 Feb 2015 00:04:50 +0100 [thread overview]
Message-ID: <20150225230449.GM3226@pd.tnic> (raw)
In-Reply-To: <1424822419-10267-4-git-send-email-dvlasenk@redhat.com>
On Wed, Feb 25, 2015 at 01:00:16AM +0100, Denys Vlasenko wrote:
> After TEST insn, JE actually performs "jump if zero",
> let's use JZ mnemonic instead.
>
> No code changes, but less confusion.
>
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Linus Torvalds <torvalds@linux-foundation.org>
> CC: Steven Rostedt <rostedt@goodmis.org>
> CC: Ingo Molnar <mingo@kernel.org>
> CC: Borislav Petkov <bp@alien8.de>
> CC: "H. Peter Anvin" <hpa@zytor.com>
> CC: Andy Lutomirski <luto@amacapital.net>
> CC: Oleg Nesterov <oleg@redhat.com>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Alexei Starovoitov <ast@plumgrid.com>
> CC: Will Drewry <wad@chromium.org>
> CC: Kees Cook <keescook@chromium.org>
> CC: x86@kernel.org
> CC: linux-kernel@vger.kernel.org
> ---
> arch/x86/kernel/entry_64.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-02-25 23:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 0:00 [PATCH 1/7] x86: ia32entry.S: use more understandable constant Denys Vlasenko
2015-02-25 0:00 ` [PATCH 2/7] x86: entry.S: simplify optimistic SYSRET Denys Vlasenko
2015-02-25 0:04 ` Andy Lutomirski
2015-02-25 0:31 ` Denys Vlasenko
2015-02-25 0:00 ` [PATCH 3/7] x86: entry.S: use smaller insns Denys Vlasenko
2015-02-25 0:00 ` [PATCH 4/7] x86: entry.S: use JZ mnemonic after TEST, not JE Denys Vlasenko
2015-02-25 23:04 ` Borislav Petkov [this message]
2015-02-26 14:13 ` Denys Vlasenko
2015-02-26 15:16 ` Andy Lutomirski
2015-02-26 15:59 ` Borislav Petkov
2015-02-26 16:03 ` Andy Lutomirski
2015-02-26 19:21 ` Borislav Petkov
2015-02-25 0:00 ` [PATCH 5/7 v2] x86: get rid of KERNEL_STACK_OFFSET Denys Vlasenko
2015-02-25 1:11 ` Andy Lutomirski
2015-02-25 0:00 ` [PATCH 6/7 v2] x86: save r11 into pt_regs->eflags on SYSCALL64 fastpath Denys Vlasenko
2015-02-25 0:00 ` [PATCH 7/7 v2] x86: save user %rsp in pt_regs->sp Denys Vlasenko
2015-02-25 0:03 ` [PATCH 1/7] x86: ia32entry.S: use more understandable constant Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225230449.GM3226@pd.tnic \
--to=bp@alien8.de \
--cc=ast@plumgrid.com \
--cc=dvlasenk@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox