From: Tejun Heo <tj@kernel.org>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Stefan Bader <stefan.bader@canonical.com>,
Sander Eikelenboom <linux@eikelenboom.it>,
linux-kernel@vger.kernel.org
Subject: Re: 3.19: device name associates with IRQ's for ahci controllers operating with a single IRQ changed from "ahci?" to "<BDF>"
Date: Mon, 2 Mar 2015 14:10:49 -0500 [thread overview]
Message-ID: <20150302191049.GA8051@htj.duckdns.org> (raw)
In-Reply-To: <20150302185809.GA23808@agordeev.usersys.redhat.com>
On Mon, Mar 02, 2015 at 06:58:10PM +0000, Alexander Gordeev wrote:
> On Mon, Mar 02, 2015 at 12:21:08PM -0500, Tejun Heo wrote:
> > Hello,
> >
> > On Mon, Feb 16, 2015 at 05:28:42PM +0000, Alexander Gordeev wrote:
> > > The problem dates back to commit 4f37b50 ("libata: Use dev_name() for
> > > request_irq() to distinguish devices"). If the commit is considered valid
> > > then <BDF> still might be legitimate as well. Not sure what is the best
> > > approach here.
> >
> > What does <BDF> indicate? Does it successfully identify the device in
> > question?
>
> I suppose, PCI bus-device-function.
> Yes, it does.
Hmmm... it does stand out like a sore thumb and we probably should use
a more descriptive identifier including the driver name. 4f37b50
("libata: Use dev_name() was fine for the specific platform device as
the device identifier included ide but not generally. :(
How about driver name followed by device ID?
Thanks.
--
tejun
next prev parent reply other threads:[~2015-03-02 19:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 19:54 3.19: device name associates with IRQ's for ahci controllers operating with a single IRQ changed from "ahci?" to "<BDF>" Sander Eikelenboom
2015-02-10 7:57 ` Stefan Bader
2015-02-10 14:51 ` Tejun Heo
2015-02-12 16:33 ` Alexander Gordeev
2015-02-16 17:28 ` Alexander Gordeev
2015-03-02 17:21 ` Tejun Heo
2015-03-02 18:58 ` Alexander Gordeev
2015-03-02 19:10 ` Tejun Heo [this message]
2015-03-02 19:20 ` Tejun Heo
2015-03-02 19:11 ` Sander Eikelenboom
2015-03-02 19:12 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302191049.GA8051@htj.duckdns.org \
--to=tj@kernel.org \
--cc=agordeev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@eikelenboom.it \
--cc=stefan.bader@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox