From: Mark Brown <broonie@kernel.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [RFC PATCH] spi: Ensure that CS line is in non-active state after setup
Date: Sun, 8 Mar 2015 20:01:42 +0000 [thread overview]
Message-ID: <20150308200142.GC28806@sirena.org.uk> (raw)
In-Reply-To: <1425656716-25363-1-git-send-email-iivanov@mm-sol.com>
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
On Fri, Mar 06, 2015 at 05:45:15PM +0200, Ivan T. Ivanov wrote:
> if (spi->master->setup)
> status = spi->master->setup(spi);
> + else
> + spi_set_cs(spi, false);
Why would this be conditional on there not being a setup operation?
It's a good idea, I just don't see why the backstop isn't always useful.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-03-08 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 15:45 [RFC PATCH] spi: Ensure that CS line is in non-active state after setup Ivan T. Ivanov
2015-03-08 20:01 ` Mark Brown [this message]
2015-03-09 7:11 ` Ivan T. Ivanov
2015-03-09 12:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150308200142.GC28806@sirena.org.uk \
--to=broonie@kernel.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox