From: Dan Carpenter <dan.carpenter@oracle.com>
To: Matteo Semenzato <mattew8898@gmail.com>
Cc: gregkh@linuxfoundation.org, abbotti@mev.co.uk,
hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix information leak
Date: Tue, 10 Mar 2015 09:44:40 +0300 [thread overview]
Message-ID: <20150310064440.GK10964@mwanda> (raw)
In-Reply-To: <1425931697-10301-1-git-send-email-mattew8898@gmail.com>
On Mon, Mar 09, 2015 at 09:08:17PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@gmail.com>
>
> The comedi_cmd struct has an hole after chanlist_len that could contain uninitialized
> memory, this struct is copied to userspace.
>
Is this a Smatch warning? If so then, I appologize because it's a false
positive. You really need to have the cross function database built for
that test to work.
The struct is initialized in __comedi_get_user_cmd().
regards,
dan carpenter
prev parent reply other threads:[~2015-03-10 6:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 20:08 [PATCH] Staging: comedi: fix information leak Matteo Semenzato
2015-03-09 23:34 ` Ian Abbott
2015-03-10 6:44 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310064440.GK10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mattew8898@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox