From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clocksource: atmel-st: select REGMAP_MMIO
Date: Thu, 19 Mar 2015 09:02:16 +0100 [thread overview]
Message-ID: <20150319090216.634797ef@bbrezillon> (raw)
In-Reply-To: <1426676795-29333-1-git-send-email-alexandre.belloni@free-electrons.com>
Hi Alexandre,
On Wed, 18 Mar 2015 12:06:35 +0100
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> Enforce REGMAP_MMIO selection as the driver needs it. Else, it will still
> compile with some warning about X1, x2 or sr being used uninitialized.
>
> Reported-by: fengguang.wu@intel.com
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> Daniel,
>
> I think this should go through the at91 tree as the patch introducing that issue
> went there.
>
> drivers/clocksource/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 168035883afa..3cc97b217019 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -146,6 +146,7 @@ config ATMEL_PIT
> config ATMEL_ST
> bool
> select CLKSRC_OF
> + select REGMAP_MMIO
Shouldn't we select MFD_SYSCON instead.
Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-19 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 11:06 [PATCH] clocksource: atmel-st: select REGMAP_MMIO Alexandre Belloni
2015-03-19 8:02 ` Boris Brezillon [this message]
2015-03-19 12:53 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319090216.634797ef@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox