public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: perf: thread is its own parent
Date: Thu, 19 Mar 2015 10:27:50 -0400	[thread overview]
Message-ID: <20150319142750.GH162412@redhat.com> (raw)
In-Reply-To: <550AD590.9090904@gmail.com>

On Thu, Mar 19, 2015 at 07:56:32AM -0600, David Ahern wrote:
> On 3/19/15 7:20 AM, Don Zickus wrote:
> >Honestly I don't recall.   The commit log tells you the problem I was trying
> >to solve.  Instead of parsing text strings from/proc/maps/<pid>, I believe
> >it was waaaay faster to copy the thread maps.
> >
> >This could have been an oversight.  I might have falsely assumed tgid ==
> >ppid?
> >
> >Are you finding a problem with it?
> 
> 
> rebasing my scheduling timehist command to 4.0 and this change
> breaks one of the options. If there are no objections I'll send a
> patch along with others to set ptid and ppid to -1 (that's what it
> is in 3.12).

Hmm, I wonder if this is going to break our threading example.  Perhaps not,
now that Jiri made some other changes later.  Feel free to post a patch, cc
me please.  I will patch our perf over here and have Joe Mario run some
tests to see if we lose any data or not and let you know.

Cheers,
Don

      reply	other threads:[~2015-03-19 14:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 23:56 perf: thread is its own parent David Ahern
2015-03-19 13:20 ` Don Zickus
2015-03-19 13:56   ` David Ahern
2015-03-19 14:27     ` Don Zickus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150319142750.GH162412@redhat.com \
    --to=dzickus@redhat.com \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox