public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jan Stancek <jstancek@redhat.com>, linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, paulus@samba.org, anton@samba.org,
	tj@kernel.org, cl@linux.com, jolsa@redhat.com,
	jstancek@redhat.com, joel@jms.id.au
Subject: Re: powerpc/perf: add missing put_cpu_var in power_pmu_event_init
Date: Wed, 25 Mar 2015 16:25:09 +1100 (AEDT)	[thread overview]
Message-ID: <20150325052509.C995F1400F1@ozlabs.org> (raw)
In-Reply-To: <aa8dd4f5b50686871c9d3a1c27337006b1c9eea9.1427200114.git.jstancek@redhat.com>

On Tue, 2015-24-03 at 12:33:22 UTC, Jan Stancek wrote:
> One path in power_pmu_event_init() calls get_cpu_var(), but is
> missing matching call to put_cpu_var(), which causes preemption
> imbalance and crash in user-space:
> 
>   Page fault in user mode with in_atomic() = 1 mm = c000001fefa5a280
>   NIP = 3fff9bf2cae0  MSR = 900000014280f032
>   Oops: Weird page fault, sig: 11 [#23]

<snip>

Thanks. But I don't see this. I guess you have CONFIG_PREEMPT enabled?

cheers

  reply	other threads:[~2015-03-25  5:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 12:33 [PATCH] powerpc/perf: add missing put_cpu_var in power_pmu_event_init Jan Stancek
2015-03-25  5:25 ` Michael Ellerman [this message]
2015-03-25  9:29   ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150325052509.C995F1400F1@ozlabs.org \
    --to=mpe@ellerman.id.au \
    --cc=anton@samba.org \
    --cc=cl@linux.com \
    --cc=joel@jms.id.au \
    --cc=jolsa@redhat.com \
    --cc=jstancek@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox