From: Thierry Reding <thierry.reding@gmail.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] PM / devfreq: tegra: Register governor on module init
Date: Mon, 30 Mar 2015 17:08:30 +0200 [thread overview]
Message-ID: <20150330150828.GA18428@ulmo.nvidia.com> (raw)
In-Reply-To: <1427720078-28836-1-git-send-email-tomeu.vizoso@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
On Mon, Mar 30, 2015 at 02:54:38PM +0200, Tomeu Vizoso wrote:
[...]
> +static int __init tegra_devfreq_init(void)
> +{
> + int ret = 0;
> +
> + ret = devfreq_add_governor(&tegra_devfreq_governor);
> + if (ret) {
> + pr_err("%s: failed to add governor: %d\n", __func__, ret);
> + return ret;
> + }
> +
> + return platform_driver_register(&tegra_devfreq_driver);
Shouldn't you remove the governor on driver registration failure?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-30 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 10:22 [PATCH v6 2/8] PM / devfreq: tegra: Update to v5 of the submitted patches MyungJoo Ham
2015-03-30 12:54 ` [PATCH] PM / devfreq: tegra: Register governor on module init Tomeu Vizoso
2015-03-30 15:08 ` Thierry Reding [this message]
2015-03-30 15:33 ` [PATCH v2] " Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330150828.GA18428@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=gnurou@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=swarren@wwwdotorg.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox