public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: xiaoming.wang@intel.com,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	mgorman@suse.de, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] proc: move the adding option Ngid to the end of proc/PID/status
Date: Fri, 17 Apr 2015 10:26:05 -0400	[thread overview]
Message-ID: <20150417142605.GA1954@htj.duckdns.org> (raw)
In-Reply-To: <CACVxJT_6O7bAMOQYDWfNgiVabPEot-o+bhO68wmdMT32cEsoww@mail.gmail.com>

Hey,

On Fri, Apr 17, 2015 at 04:23:48PM +0300, Alexey Dobriyan wrote:
> It was demonstrated that Ngid addition as line 4 breaks apps,
> but your "what if" remains "what if".
> 
> I'd say Ngid should be moved to the end and every new field
> must be added to the end from now on, people can't parse
> simple file correctly, let's not create problems for them.

If this were in -rc or we are only a couple releases out, sure, moving
that to the end would be the right thing to do but that's not the case
and it bothers me that the patch essentially trades in about the same
magnitude of unknown risk.  No matter which way you spin it, unknown
risk of similar magnitude is not better than known risk and it's
pretty certain that we'll have all three variants out in the wild for
the foreseeable future.

If this has to happen, it should be moving Ngid right after TracerPid
not at the end of file.

Thanks.

-- 
tejun

  reply	other threads:[~2015-04-17 14:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17 13:23 [PATCH] proc: move the adding option Ngid to the end of proc/PID/status Alexey Dobriyan
2015-04-17 14:26 ` Tejun Heo [this message]
2015-04-17 15:05   ` Alexey Dobriyan
2015-04-17 15:12     ` Tejun Heo
2015-04-21  8:19       ` Wang, Xiaoming
2015-04-21 14:00       ` Alexey Dobriyan
2015-04-21 15:11         ` Tejun Heo
2015-04-23 20:32           ` Alexey Dobriyan
2015-04-24 15:50             ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2015-04-17  2:13 Wang Xiaoming
2015-04-17  2:56 ` Tejun Heo
2015-04-17  3:15   ` Wang, Xiaoming
2015-04-17  3:26     ` Tejun Heo
2015-04-17  3:37       ` Wang, Xiaoming
2015-04-17  3:42         ` Tejun Heo
2015-04-17  5:36           ` Wang, Xiaoming
2015-04-21 15:19             ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150417142605.GA1954@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=xiaoming.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox