From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org,
"Justin M. Forbes" <jforbes@fedoraproject.org>,
Jeff Moyer <jmoyer@redhat.com>, "v4.0" <stable@vger.kernel.org>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v6] block: loop: avoiding too many pending per work I/O
Date: Fri, 1 May 2015 03:17:37 -0700 [thread overview]
Message-ID: <20150501101737.GA18577@infradead.org> (raw)
In-Reply-To: <1430450881-10881-1-git-send-email-ming.lei@canonical.com>
On Fri, May 01, 2015 at 11:28:01AM +0800, Ming Lei wrote:
> If there are too many pending per work I/O, too many
> high priority work thread can be generated so that
> system performance can be effected.
>
> This patch limits the max pending per work I/O as 16,
> and will fackback to single queue mode when the max
> number is reached.
Why would you do this fall back? Shouldn't we just communicate
a concurrency limit to the workqueue code?
next prev parent reply other threads:[~2015-05-01 10:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 3:28 [PATCH v6] block: loop: avoiding too many pending per work I/O Ming Lei
2015-05-01 10:17 ` Christoph Hellwig [this message]
2015-05-01 13:36 ` Ming Lei
2015-05-01 14:22 ` Tejun Heo
2015-05-01 15:05 ` Christoph Hellwig
2015-05-01 15:47 ` Tejun Heo
2015-05-02 15:09 ` Ming Lei
2015-05-02 14:56 ` Ming Lei
2015-05-03 1:52 ` Tejun Heo
2015-05-04 12:54 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501101737.GA18577@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jforbes@fedoraproject.org \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox