From: Christoph Hellwig <hch@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Ming Lei <ming.lei@canonical.com>,
Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Justin M. Forbes" <jforbes@fedoraproject.org>,
Jeff Moyer <jmoyer@redhat.com>, "v4.0" <stable@vger.kernel.org>
Subject: Re: [PATCH v6] block: loop: avoiding too many pending per work I/O
Date: Fri, 1 May 2015 08:05:45 -0700 [thread overview]
Message-ID: <20150501150545.GA10705@infradead.org> (raw)
In-Reply-To: <20150501142221.GC1949@htj.duckdns.org>
On Fri, May 01, 2015 at 10:22:21AM -0400, Tejun Heo wrote:
> > > Why would you do this fall back? Shouldn't we just communicate
> > > a concurrency limit to the workqueue code?
> >
> > It can't work with workqueue's concurrency limit because the
> > queue is shared by all loop block devices, and the limit is on the
> > whole queue.
>
> Maybe just cap max_active to NR_OF_LOOP_DEVS * 16 or sth? But idk,
> how many concurrent workers are we talking about and why are we
> capping per-queue concurrency from worker pool side instead of command
> tag side?
Also we probably should have per device workqueues to start with..
next prev parent reply other threads:[~2015-05-01 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 3:28 [PATCH v6] block: loop: avoiding too many pending per work I/O Ming Lei
2015-05-01 10:17 ` Christoph Hellwig
2015-05-01 13:36 ` Ming Lei
2015-05-01 14:22 ` Tejun Heo
2015-05-01 15:05 ` Christoph Hellwig [this message]
2015-05-01 15:47 ` Tejun Heo
2015-05-02 15:09 ` Ming Lei
2015-05-02 14:56 ` Ming Lei
2015-05-03 1:52 ` Tejun Heo
2015-05-04 12:54 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501150545.GA10705@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jforbes@fedoraproject.org \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox