public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v2 1/2] mfd: arizona: Add stub for wm5102_patch()
Date: Wed, 13 May 2015 17:51:28 +0100	[thread overview]
Message-ID: <20150513165128.GD19543@x1> (raw)
In-Reply-To: <1431532346-10851-1-git-send-email-rf@opensource.wolfsonmicro.com>

On Wed, 13 May 2015, Richard Fitzgerald wrote:

> For the WM5102 there is a dependency in the core code on wm5102_patch()
> which only exists when CONFIG_MFD_WM5102 is defined. To avoid having
> to sprinkle #ifdefs around the code it is given an alternative empty
> stub version when CONFIG_MFD_WM5102 is deselected
> 
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
>  include/linux/mfd/arizona/core.h |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)

Applied, thanks.

> diff --git a/include/linux/mfd/arizona/core.h b/include/linux/mfd/arizona/core.h
> index 16a498f..7597164 100644
> --- a/include/linux/mfd/arizona/core.h
> +++ b/include/linux/mfd/arizona/core.h
> @@ -153,7 +153,15 @@ int arizona_request_irq(struct arizona *arizona, int irq, char *name,
>  void arizona_free_irq(struct arizona *arizona, int irq, void *data);
>  int arizona_set_irq_wake(struct arizona *arizona, int irq, int on);
>  
> +#ifdef CONFIG_MFD_WM5102
>  int wm5102_patch(struct arizona *arizona);
> +#else
> +static inline int wm5102_patch(struct arizona *arizona)
> +{
> +	return 0;
> +}
> +#endif
> +
>  int wm5110_patch(struct arizona *arizona);
>  int wm8997_patch(struct arizona *arizona);
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

      parent reply	other threads:[~2015-05-13 16:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 15:52 [PATCH v2 1/2] mfd: arizona: Add stub for wm5102_patch() Richard Fitzgerald
2015-05-13 15:52 ` [PATCH v2 2/2] mfd: arizona: Fix incorrect Makefile conditionals Richard Fitzgerald
2015-05-13 16:51   ` Lee Jones
2015-05-13 16:51 ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150513165128.GD19543@x1 \
    --to=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=rf@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox