From: Lee Jones <lee.jones@linaro.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v2 2/2] mfd: arizona: Fix incorrect Makefile conditionals
Date: Wed, 13 May 2015 17:51:40 +0100 [thread overview]
Message-ID: <20150513165140.GE19543@x1> (raw)
In-Reply-To: <1431532346-10851-2-git-send-email-rf@opensource.wolfsonmicro.com>
On Wed, 13 May 2015, Richard Fitzgerald wrote:
> The use of ifneq against 'n' to conditionally compile codec-specific
> parts is wrong and was resulting in all the codec tables being built
> even for deselected codecs.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/Makefile | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index ca6d184..63743a7 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -41,13 +41,13 @@ obj-$(CONFIG_MFD_ARIZONA) += arizona-core.o
> obj-$(CONFIG_MFD_ARIZONA) += arizona-irq.o
> obj-$(CONFIG_MFD_ARIZONA_I2C) += arizona-i2c.o
> obj-$(CONFIG_MFD_ARIZONA_SPI) += arizona-spi.o
> -ifneq ($(CONFIG_MFD_WM5102),n)
> +ifeq ($(CONFIG_MFD_WM5102),y)
> obj-$(CONFIG_MFD_ARIZONA) += wm5102-tables.o
> endif
> -ifneq ($(CONFIG_MFD_WM5110),n)
> +ifeq ($(CONFIG_MFD_WM5110),y)
> obj-$(CONFIG_MFD_ARIZONA) += wm5110-tables.o
> endif
> -ifneq ($(CONFIG_MFD_WM8997),n)
> +ifeq ($(CONFIG_MFD_WM8997),y)
> obj-$(CONFIG_MFD_ARIZONA) += wm8997-tables.o
> endif
> obj-$(CONFIG_MFD_WM8400) += wm8400-core.o
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-05-13 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 15:52 [PATCH v2 1/2] mfd: arizona: Add stub for wm5102_patch() Richard Fitzgerald
2015-05-13 15:52 ` [PATCH v2 2/2] mfd: arizona: Fix incorrect Makefile conditionals Richard Fitzgerald
2015-05-13 16:51 ` Lee Jones [this message]
2015-05-13 16:51 ` [PATCH v2 1/2] mfd: arizona: Add stub for wm5102_patch() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513165140.GE19543@x1 \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox