From: Jiri Olsa <jolsa@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Milos Vyletel <milos@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
He Kuang <hekuang@huawei.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"open list:PERFORMANCE EVENT..." <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] perf/tools: put new buildid locks to use
Date: Thu, 14 May 2015 13:38:21 +0200 [thread overview]
Message-ID: <20150514113821.GB1313@krava.redhat.com> (raw)
In-Reply-To: <20150514104059.GA27771@gmail.com>
On Thu, May 14, 2015 at 12:40:59PM +0200, Ingo Molnar wrote:
>
> * Milos Vyletel <milos@redhat.com> wrote:
>
> > Use new read/write locks when accesing buildid directory on places where
> > we may race if multiple instances are run simultaneously.
>
> Dunno, this will create locking interaction between multiple instances
> of perf - hanging each other, etc.
>
> And it seems unnecessary: the buildid hierarchy is already spread out.
> What kind of races might there be?
there was just recently one fixed by commit:
0635b0f71424 perf tools: Fix race in build_id_cache__add_s()
havent checked the final patch yet, but the idea is to
protect us from similar bugs
jirka
next prev parent reply other threads:[~2015-05-14 11:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 7:28 [PATCH 0/2] Add perf debug dir locking Milos Vyletel
2015-05-14 7:28 ` [PATCH 1/2] perf/tools: add read/write buildid dir locks Milos Vyletel
2015-05-14 7:28 ` [PATCH 2/2] perf/tools: put new buildid locks to use Milos Vyletel
2015-05-14 10:40 ` Ingo Molnar
2015-05-14 11:38 ` Jiri Olsa [this message]
2015-05-14 15:44 ` Milos Vyletel
2015-05-14 17:38 ` Ingo Molnar
2015-05-14 17:38 ` Ingo Molnar
2015-05-20 7:27 ` Milos Vyletel
2015-06-03 11:13 ` Milos Vyletel
2015-06-03 11:21 ` Ingo Molnar
2015-06-03 11:27 ` Milos Vyletel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514113821.GB1313@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=milos@redhat.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox