The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000
@ 2015-04-28 20:24 Marek Belisko
  2015-04-30 13:30 ` Evgeniy Polyakov
  0 siblings, 1 reply; 5+ messages in thread
From: Marek Belisko @ 2015-04-28 20:24 UTC (permalink / raw)
  To: zbr; +Cc: linux-kernel, hns, Marek Belisko

bq2700 slave driver depends on bq27x00-battery driver thus adding this
dependency to config. When bq2700 is build as module bq27x00-battery
will be loaded automatically.

Signed-off-by: Marek Belisko <marek@goldelico.com>
---
 drivers/w1/slaves/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/w1/slaves/Kconfig b/drivers/w1/slaves/Kconfig
index cfe74d0..15c230a 100644
--- a/drivers/w1/slaves/Kconfig
+++ b/drivers/w1/slaves/Kconfig
@@ -128,6 +128,7 @@ config W1_SLAVE_DS28E04
 
 config W1_SLAVE_BQ27000
 	tristate "BQ27000 slave support"
+	depends on BATTERY_BQ27X00_PLATFORM
 	help
 	  Say Y here if you want to use a hdq
 	  bq27000 slave support.
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000
  2015-04-28 20:24 [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000 Marek Belisko
@ 2015-04-30 13:30 ` Evgeniy Polyakov
  2015-04-30 13:37   ` Belisko Marek
  0 siblings, 1 reply; 5+ messages in thread
From: Evgeniy Polyakov @ 2015-04-30 13:30 UTC (permalink / raw)
  To: Marek Belisko; +Cc: linux-kernel@vger.kernel.org, hns@goldelico.com

HI Marek

28.04.2015, 23:25, "Marek Belisko" <marek@goldelico.com>:
> bq2700 slave driver depends on bq27x00-battery driver thus adding this
> dependency to config. When bq2700 is build as module bq27x00-battery
> will be loaded automatically.
>
> Signed-off-by: Marek Belisko <marek@goldelico.com>

Patch looks good to me, but you should add appropriate maintainer to copy,
since I know nothing about bq27000 device.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000
  2015-04-30 13:30 ` Evgeniy Polyakov
@ 2015-04-30 13:37   ` Belisko Marek
  2015-05-15 19:57     ` Belisko Marek
  0 siblings, 1 reply; 5+ messages in thread
From: Belisko Marek @ 2015-04-30 13:37 UTC (permalink / raw)
  To: Evgeniy Polyakov
  Cc: linux-kernel@vger.kernel.org, hns@goldelico.com,
	Sebastian Reichel

+CC Sebastian

On Thu, Apr 30, 2015 at 3:30 PM, Evgeniy Polyakov <zbr@ioremap.net> wrote:
> HI Marek
>
> 28.04.2015, 23:25, "Marek Belisko" <marek@goldelico.com>:
>> bq2700 slave driver depends on bq27x00-battery driver thus adding this
>> dependency to config. When bq2700 is build as module bq27x00-battery
>> will be loaded automatically.
>>
>> Signed-off-by: Marek Belisko <marek@goldelico.com>
>
> Patch looks good to me, but you should add appropriate maintainer to copy,
> since I know nothing about bq27000 device.

Sebastian could you please add your Ack to this change or comment if
you disagree? Thanks.

BR,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000
  2015-04-30 13:37   ` Belisko Marek
@ 2015-05-15 19:57     ` Belisko Marek
  2015-05-15 21:00       ` Sebastian Reichel
  0 siblings, 1 reply; 5+ messages in thread
From: Belisko Marek @ 2015-05-15 19:57 UTC (permalink / raw)
  To: Evgeniy Polyakov
  Cc: linux-kernel@vger.kernel.org, hns@goldelico.com,
	Sebastian Reichel

Sebastian ping. Thanks.

On Thu, Apr 30, 2015 at 3:37 PM, Belisko Marek <marek.belisko@gmail.com> wrote:
> +CC Sebastian
>
> On Thu, Apr 30, 2015 at 3:30 PM, Evgeniy Polyakov <zbr@ioremap.net> wrote:
>> HI Marek
>>
>> 28.04.2015, 23:25, "Marek Belisko" <marek@goldelico.com>:
>>> bq2700 slave driver depends on bq27x00-battery driver thus adding this
>>> dependency to config. When bq2700 is build as module bq27x00-battery
>>> will be loaded automatically.
>>>
>>> Signed-off-by: Marek Belisko <marek@goldelico.com>
>>
>> Patch looks good to me, but you should add appropriate maintainer to copy,
>> since I know nothing about bq27000 device.
>
> Sebastian could you please add your Ack to this change or comment if
> you disagree? Thanks.
>
> BR,
>
> marek
>
> --
> as simple and primitive as possible
> -------------------------------------------------
> Marek Belisko - OPEN-NANDRA
> Freelance Developer
>
> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
> Tel: +421 915 052 184
> skype: marekwhite
> twitter: #opennandra
> web: http://open-nandra.com

BR,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000
  2015-05-15 19:57     ` Belisko Marek
@ 2015-05-15 21:00       ` Sebastian Reichel
  0 siblings, 0 replies; 5+ messages in thread
From: Sebastian Reichel @ 2015-05-15 21:00 UTC (permalink / raw)
  To: Belisko Marek
  Cc: Evgeniy Polyakov, linux-kernel@vger.kernel.org, hns@goldelico.com

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

Hi,

On Fri, May 15, 2015 at 09:57:38PM +0200, Belisko Marek wrote:
> 
> On Thu, Apr 30, 2015 at 3:37 PM, Belisko Marek <marek.belisko@gmail.com> wrote:
> > +CC Sebastian
> >
> > On Thu, Apr 30, 2015 at 3:30 PM, Evgeniy Polyakov <zbr@ioremap.net> wrote:
> >> HI Marek
> >>
> >> 28.04.2015, 23:25, "Marek Belisko" <marek@goldelico.com>:
> >>> bq2700 slave driver depends on bq27x00-battery driver thus adding this
> >>> dependency to config. When bq2700 is build as module bq27x00-battery
> >>> will be loaded automatically.
> >>>
> >>> Signed-off-by: Marek Belisko <marek@goldelico.com>
> >>
> >> Patch looks good to me, but you should add appropriate maintainer to copy,
> >> since I know nothing about bq27000 device.
> >
> > Sebastian could you please add your Ack to this change or comment if
> > you disagree? Thanks.
>
> Sebastian ping. Thanks.

Sorry, did not noticed this thread so far:

Acked-By: Sebastian Reichel <sre@kernel.org>

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-05-15 21:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-28 20:24 [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000 Marek Belisko
2015-04-30 13:30 ` Evgeniy Polyakov
2015-04-30 13:37   ` Belisko Marek
2015-05-15 19:57     ` Belisko Marek
2015-05-15 21:00       ` Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox