From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Amaury Denoyelle <amaury.denoyelle@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Staging: comedi: fix line longer than 80 chars in cb_pcidas64.c
Date: Mon, 18 May 2015 10:07:00 +0530 [thread overview]
Message-ID: <20150518043528.GA3547@sudip-PC> (raw)
In-Reply-To: <1431874043-8153-1-git-send-email-amaury.denoyelle@gmail.com>
On Sun, May 17, 2015 at 04:47:23PM +0200, Amaury Denoyelle wrote:
> This patch fixes coding style errors reported by checkpatch.pl for
> cb_pcidas64.c, about too long source code lines.
>
> Signed-off-by: Amaury Denoyelle <amaury.denoyelle@gmail.com>
> ---
<snip>
> }
>
> -/* adjusts the size of hardware fifo (which determines block size for dma xfers) */
> +/* adjusts the size of hardware fifo
> + * (which determines block size for dma xfers) */
This is not the style for multi-line comments. Please check CodingStyle
in Documentation.
> static int set_ai_fifo_size(struct comedi_device *dev, unsigned int num_samples)
> {
<snip>
>
> @@ -1987,8 +1990,8 @@ static unsigned int get_divisor(unsigned int ns, unsigned int flags)
>
> /* utility function that rounds desired timing to an achievable time, and
> * sets cmd members appropriately.
> - * adc paces conversions from master clock by dividing by (x + 3) where x is 24 bit number
> - */
> + * adc paces conversions from master clock by dividing by (x + 3) where x is
> + * 24 bit number */
same here
and when you are sending just one patch, you do not need to mention
[Patch 1/1] in the subject. just mention [Patch]
regards
sudip
next prev parent reply other threads:[~2015-05-18 4:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-17 14:47 [PATCH 1/1] Staging: comedi: fix line longer than 80 chars in cb_pcidas64.c Amaury Denoyelle
2015-05-18 4:37 ` Sudip Mukherjee [this message]
2015-05-18 17:56 ` [PATCH v2] " Amaury Denoyelle
2015-05-18 18:51 ` Amaury Denoyelle
2015-05-19 5:47 ` Sudip Mukherjee
2015-05-19 17:57 ` [PATCH v3 0/2] staging: comedi: fix coding style " Amaury Denoyelle
2015-05-19 17:57 ` [PATCH v3 1/2] Staging: comedi: fix line longer than 80 chars " Amaury Denoyelle
2015-05-20 5:02 ` Sudip Mukherjee
2015-05-20 7:24 ` Amaury Denoyelle
2015-05-20 8:22 ` Sudip Mukherjee
2015-05-20 9:00 ` Ian Abbott
2015-05-20 9:29 ` Sudip Mukherjee
2015-05-20 8:59 ` Ian Abbott
2015-05-19 17:57 ` [PATCH v3 2/2] Staging: comedi: fix style for multi-line comments " Amaury Denoyelle
2015-05-20 8:59 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518043528.GA3547@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=amaury.denoyelle@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox