From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 2/2] PM / sleep: Make ->enter_freeze callbacks depend on CONFIG_SUSPEND
Date: Tue, 19 May 2015 17:00:26 +0200 [thread overview]
Message-ID: <20150519150026.GE3644@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <4721283.2H3KXdSq7L@vostro.rjw.lan>
On Mon, May 18, 2015 at 11:45:10PM +0200, Rafael J. Wysocki wrote:
> On Monday, May 18, 2015 02:18:26 PM Peter Zijlstra wrote:
> > On Sat, May 16, 2015 at 01:38:48AM +0200, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > >
> > > The ->enter_freeze callbacks of cpuidle drivers are only used if
> > > CONFIG_SUSPEND is set, so make them explicitly depend on that
> > > Kconfig option.
> >
> > No real objection, but is it worth it to sprinkle that CONFIG stuff over
> > all drivers?
>
> Well, you maybe right that it isn't. The footprint is small anyway.
>
> What about [1/2]?
1/2 looks fine to me.
prev parent reply other threads:[~2015-05-19 15:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 23:37 [PATCH 0/2] PM: Avoid building suspend-to-idle code when it is not necessary Rafael J. Wysocki
2015-05-15 23:38 ` [PATCH 1/2] PM / sleep: Make suspend-to-idle-specific code depend on CONFIG_SUSPEND Rafael J. Wysocki
2015-05-18 14:49 ` Thomas Gleixner
2015-05-18 21:50 ` Rafael J. Wysocki
2015-05-19 14:36 ` Daniel Lezcano
2015-05-15 23:38 ` [PATCH 2/2] PM / sleep: Make ->enter_freeze callbacks " Rafael J. Wysocki
2015-05-18 12:18 ` Peter Zijlstra
2015-05-18 21:45 ` Rafael J. Wysocki
2015-05-19 15:00 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519150026.GE3644@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=daniel.lezcano@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox