From: Nicholas Mc Guire <der.herr@hofr.at>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Davidlohr Bueso <dave@stgolabs.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: me_daq: use schedule_timeout_interruptible()
Date: Fri, 29 May 2015 18:47:28 +0200 [thread overview]
Message-ID: <20150529164728.GA11892@opentech.at> (raw)
In-Reply-To: <55689582.1000700@mev.co.uk>
On Fri, 29 May 2015, Ian Abbott wrote:
> On 29/05/15 16:58, Nicholas Mc Guire wrote:
>> API consolidation with coccinelle found:
>> ./drivers/staging/comedi/drivers/me_daq.c:177:1-17:
>> consolidation with schedule_timeout_*() recommended
>>
>> This is a 1:1 conversion of the current calls to an available helper
>> only - so only an API consolidation to improve readability.
>>
>> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
>> CONFIG_COMEDI=y, CONFIG_COMEDI_PCI_DRIVERS=y CONFIG_COMEDI_ME_DAQ=m
>>
>> Patch is against 4.1-rc5 (localversion-next is -next-20150529)
>
> Minor niggle: you don't really need to say what version the patch is
> against in the commit message, as the version will have changed by the
> time the patch is committed. It can be mentioned after the "---" marker
> line if relevant, as the stuff after the "---" line does not end up in
> the commit message.
>
makes sense - will move that down for the other cleanups.
thx!
hofrat
next prev parent reply other threads:[~2015-05-29 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 15:58 [PATCH] staging: me_daq: use schedule_timeout_interruptible() Nicholas Mc Guire
2015-05-29 16:36 ` Ian Abbott
2015-05-29 16:47 ` Nicholas Mc Guire [this message]
2015-05-31 1:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529164728.GA11892@opentech.at \
--to=der.herr@hofr.at \
--cc=abbotti@mev.co.uk \
--cc=dave@stgolabs.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hofrat@osadl.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox