From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Rachel Kim <rachel.kim@atmel.com>, Dean Lee <dean.lee@atmel.com>,
Chris Park <chris.park@atmel.com>,
devel@driverdev.osuosl.org, nicolas.ferre@atmel.com,
Johnny Kim <johnny.kim@atmel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/16] staging: wilc1000: remove semaphore wrapper
Date: Sat, 30 May 2015 12:16:54 +0530 [thread overview]
Message-ID: <20150530064654.GF31685@sudip-PC> (raw)
In-Reply-To: <1432932747-3739705-15-git-send-email-arnd@arndb.de>
On Fri, May 29, 2015 at 10:52:25PM +0200, Arnd Bergmann wrote:
> The various semaphore functions all directly translate into
> sema_init(), down() and up(), so we can just remove the API.
>
> This is a mostly automated conversion using simple sed scripts,
> plus some manual changes to account for down() returning no
> error.
>
> As a positive side-effect, down() no longer hangs after
> receiving a signal, as the original code did by looping around
> down_interruptible.
>
> The semaphores still need to be turned into mutexes as a
> follow-up step.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 29 +---
> drivers/staging/wilc1000/fifo_buffer.c | 108 +++++++-------
> drivers/staging/wilc1000/fifo_buffer.h | 2 +-
> drivers/staging/wilc1000/host_interface.c | 171 +++++++++-------------
> drivers/staging/wilc1000/host_interface.h | 16 +-
> drivers/staging/wilc1000/wilc_msgqueue.c | 32 ++--
> drivers/staging/wilc1000/wilc_oswrapper.h | 3 -
> drivers/staging/wilc1000/wilc_platform.h | 4 +-
> drivers/staging/wilc1000/wilc_semaphore.c | 56 -------
> drivers/staging/wilc1000/wilc_semaphore.h | 99 -------------
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 35 ++---
> drivers/staging/wilc1000/wilc_wfi_netdevice.h | 4 +-
> 12 files changed, 160 insertions(+), 399 deletions(-)
> delete mode 100644 drivers/staging/wilc1000/wilc_semaphore.c
> delete mode 100644 drivers/staging/wilc1000/wilc_semaphore.h
wilc_semaphore still remains in the Makefile.
regards
sudip
next prev parent reply other threads:[~2015-05-30 6:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 20:52 [PATCH 00/16] wilc1000: dead code removal and other cleanup Arnd Bergmann
2015-05-29 20:52 ` [PATCH 01/16] staging: wilc1000: remove linux version checks Arnd Bergmann
2015-05-29 20:52 ` [PATCH 02/16] staging: wilc1000: remove platform " Arnd Bergmann
2015-05-29 20:52 ` [PATCH 03/16] staging: wilc1000: remove thread wrapper Arnd Bergmann
2015-05-29 20:52 ` [PATCH 04/16] staging: wilc1000: remove __DRIVER_VERSION__ macro Arnd Bergmann
2015-05-29 20:52 ` [PATCH 05/16] staging: wilc1000: remove time wrapper Arnd Bergmann
2015-05-30 6:39 ` Sudip Mukherjee
2015-05-30 23:58 ` Greg KH
2015-06-01 19:09 ` Arnd Bergmann
2015-05-29 20:52 ` [PATCH 06/16] staging: wilc1000: remove unused string functions Arnd Bergmann
2015-05-29 20:52 ` [PATCH 07/16] staging: wilc1000: simplify msgqueue code Arnd Bergmann
2015-05-29 20:52 ` [PATCH 08/16] staging: wilc1000: remove unused memory handling code Arnd Bergmann
2015-05-29 20:52 ` [PATCH 09/16] staging: wilc1000: simplify semaphore wrapper Arnd Bergmann
2015-05-29 20:52 ` [PATCH 10/16] staging: wilc1000: clean up sleep wrapper Arnd Bergmann
2015-05-29 20:52 ` [PATCH 11/16] staging: wilc1000: clean up timer feature Arnd Bergmann
2015-05-29 20:52 ` [PATCH 12/16] staging: wilc1000: remove unused OS abstraction features Arnd Bergmann
2015-05-29 20:52 ` [PATCH 13/16] staging: wilc1000: remove EXPORT_SYMTAB Arnd Bergmann
2015-05-29 20:52 ` [PATCH 14/16] staging: wilc1000: remove semaphore wrapper Arnd Bergmann
2015-05-30 6:46 ` Sudip Mukherjee [this message]
2015-05-29 20:52 ` [PATCH 15/16] staging: wilc1000: fix const cast warnings Arnd Bergmann
2015-05-29 20:52 ` [PATCH 16/16] staging: wilc1000: fix compiler warnings Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150530064654.GF31685@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=arnd@arndb.de \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox