From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, namhyung@kernel.org,
masami.hiramatsu.pt@hitachi.com, a.p.zijlstra@chello.nl,
mingo@redhat.com, jolsa@kernel.org, linux-kernel@vger.kernel.org,
pi3orama@163.com, lizefan@huawei.com, hekuang@huawei.com
Subject: Re: [PATCH] perf tools: Move libtraceevent dynamic list to separated LDFLAGS variable
Date: Wed, 17 Jun 2015 20:28:44 +0200 [thread overview]
Message-ID: <20150617182844.GB18600@krava> (raw)
In-Reply-To: <1434552389-89144-1-git-send-email-wangnan0@huawei.com>
On Wed, Jun 17, 2015 at 02:46:29PM +0000, Wang Nan wrote:
> Commit e3d09ec8126fe2c9a3ade661e2126e215ca27a80 ("tools lib traceevent:
> Export dynamic symbols used by traceevent plugins") adds libtraceevent
> dynamic list directly into LDFLAGS, which makes all targets depend on
> that list through LDFLAGS. This is not good since some of targets like
> libgtk.so doesn't use plugin at all, but require the existance of that
> list because of linker options.
>
> This patch isolates the -Xlink option into LIBTRACEEVENT_DYNAMIC_LIST_LDFLAGS,
> makes only perf and perf.so use it.
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2015-06-17 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 14:46 [PATCH] perf tools: Move libtraceevent dynamic list to separated LDFLAGS variable Wang Nan
2015-06-17 18:28 ` Jiri Olsa [this message]
2015-06-18 8:16 ` [tip:perf/core] " tip-bot for Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617182844.GB18600@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox