Re: [bp:tip-mm 11/13] drivers/video/fbdev/aty/atyfb_base.c:3461:2: error: implicit declaration of function 'ioremap_uc'

Re: [bp:tip-mm 11/13] drivers/video/fbdev/aty/atyfb_base.c:3461:2: error: implicit declaration of function 'ioremap_uc'

[Borislav Petkov]

On Fri, Jun 26, 2015 at 04:28:51PM +0800, kbuild test robot wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp tip-mm
> head:   7b0982330a1b4d4bdb99bb8382e2363165231a90
> commit: fd50bea9cedd8fdbd091dfccb4b526be0ef9839f [11/13] drivers/video/fbdev/atyfb: Replace MTRR UC hole with strong UC
> config: xtensa-allyesconfig (attached as .config)
> reproduce:
>   wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>   chmod +x ~/bin/make.cross
>   git checkout fd50bea9cedd8fdbd091dfccb4b526be0ef9839f
>   # save the attached .config to linux build tree
>   make.cross ARCH=xtensa 

Cool script, btw. I'll use that locally too :-)

> All error/warnings (new ones prefixed by >>):
> 
>    drivers/video/fbdev/aty/atyfb_base.c: In function 'atyfb_setup_generic':
> >> drivers/video/fbdev/aty/atyfb_base.c:3461:2: error: implicit declaration of function 'ioremap_uc' [-Werror=implicit-function-declaration]
>      par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
>      ^
> >> drivers/video/fbdev/aty/atyfb_base.c:3461:19: warning: assignment makes pointer from integer without a cast
>      par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
>                       ^
>    cc1: some warnings being treated as errors
> 
> vim +/ioremap_uc +3461 drivers/video/fbdev/aty/atyfb_base.c
> 
>   3455	
>   3456		info->fix.mmio_start = raddr;
>   3457		/*
>   3458		 * By using strong UC we force the MTRR to never have an
>   3459		 * effect on the MMIO region on both non-PAT and PAT systems.
>   3460		 */
> > 3461		par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
>   3462		if (par->ati_regbase == NULL)
>   3463			return -ENOMEM;
>   3464	

Looks to me, xtensa needs something like that:

---
>From d8ac67e37a1a99e305c5ec57cff084f9f3513e61 Mon Sep 17 00:00:00 2001
From: Borislav Petkov <bp@suse.de>
Date: Fri, 26 Jun 2015 10:54:40 +0200
Subject: [PATCH] xtensa/asm: Add ioremap_uc

... and default to the uncacheable version.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: Chris Zankel <chris@zankel.net>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Toshi Kani <toshi.kani@hp.com>
Cc: linux-xtensa@linux-xtensa.org
---
 arch/xtensa/include/asm/io.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/xtensa/include/asm/io.h b/arch/xtensa/include/asm/io.h
index c39bb6e61911..34f707ea619b 100644
--- a/arch/xtensa/include/asm/io.h
+++ b/arch/xtensa/include/asm/io.h
@@ -60,6 +60,7 @@ static inline void __iomem *ioremap_cache(unsigned long offset,
 
 #define ioremap_wc ioremap_nocache
 #define ioremap_wt ioremap_nocache
+#define ioremap_uc ioremap_nocache
 
 static inline void __iomem *ioremap(unsigned long offset, unsigned long size)
 {
-- 
2.3.5

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

Re: [bp:tip-mm 11/13] drivers/video/fbdev/aty/atyfb_base.c:3461:2: error: implicit declaration of function 'ioremap_uc'

[Max Filippov]

On Fri, Jun 26, 2015 at 12:29 PM, Borislav Petkov <bp@suse.de> wrote:
> On Fri, Jun 26, 2015 at 04:28:51PM +0800, kbuild test robot wrote:
>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp tip-mm
>> head:   7b0982330a1b4d4bdb99bb8382e2363165231a90
>> commit: fd50bea9cedd8fdbd091dfccb4b526be0ef9839f [11/13] drivers/video/fbdev/atyfb: Replace MTRR UC hole with strong UC
>> config: xtensa-allyesconfig (attached as .config)
...
>> All error/warnings (new ones prefixed by >>):
>>
>>    drivers/video/fbdev/aty/atyfb_base.c: In function 'atyfb_setup_generic':
>> >> drivers/video/fbdev/aty/atyfb_base.c:3461:2: error: implicit declaration of function 'ioremap_uc' [-Werror=implicit-function-declaration]
>>      par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
>>      ^
>> >> drivers/video/fbdev/aty/atyfb_base.c:3461:19: warning: assignment makes pointer from integer without a cast
>>      par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000);
>>                       ^
...
> Looks to me, xtensa needs something like that:
>
> ---
> From d8ac67e37a1a99e305c5ec57cff084f9f3513e61 Mon Sep 17 00:00:00 2001
> From: Borislav Petkov <bp@suse.de>
> Date: Fri, 26 Jun 2015 10:54:40 +0200
> Subject: [PATCH] xtensa/asm: Add ioremap_uc
>
> ... and default to the uncacheable version.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: "Luis R. Rodriguez" <mcgrof@suse.com>
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Toshi Kani <toshi.kani@hp.com>
> Cc: linux-xtensa@linux-xtensa.org
> ---
>  arch/xtensa/include/asm/io.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/xtensa/include/asm/io.h b/arch/xtensa/include/asm/io.h
> index c39bb6e61911..34f707ea619b 100644
> --- a/arch/xtensa/include/asm/io.h
> +++ b/arch/xtensa/include/asm/io.h
> @@ -60,6 +60,7 @@ static inline void __iomem *ioremap_cache(unsigned long offset,
>
>  #define ioremap_wc ioremap_nocache
>  #define ioremap_wt ioremap_nocache
> +#define ioremap_uc ioremap_nocache
>
>  static inline void __iomem *ioremap(unsigned long offset, unsigned long size)
>  {
> --

Acked-by: Max Filippov <jcmvbkbc@gmail.com>

-- 
Thanks.
-- Max