From: Greg KH <gregkh@linuxfoundation.org>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xhci:Change function name from xhci_configure_endpoint_result to xhci_trace_endpoint_result
Date: Fri, 26 Jun 2015 11:48:05 -0700 [thread overview]
Message-ID: <20150626184805.GA1612@kroah.com> (raw)
In-Reply-To: <1435343148-6854-1-git-send-email-xerofoify@gmail.com>
On Fri, Jun 26, 2015 at 02:25:48PM -0400, Nicholas Krause wrote:
> This changes the name of the function xhci_configure_endpoint_result
> to xhci_trace_endpoint_result to more clearly state the actual
> intended use of this function which is tracing the passed command
> status, on the passed usb/xhci structure pointers of udev and xhci
> respectfully.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Dammit, my filters broke, I need to go fix them now...
> ---
> drivers/usb/host/xhci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 36bf089..2e086ef 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1839,7 +1839,7 @@ static void xhci_zero_in_ctx(struct xhci_hcd *xhci, struct xhci_virt_device *vir
> }
> }
>
> -static int xhci_configure_endpoint_result(struct xhci_hcd *xhci,
> +static int xhci_trace_endpoint_result(struct xhci_hcd *xhci,
> struct usb_device *udev, u32 *cmd_status)
> {
> int ret;
> @@ -2683,7 +2683,7 @@ static int xhci_configure_endpoint(struct xhci_hcd *xhci,
> wait_for_completion(command->completion);
>
> if (!ctx_change)
> - ret = xhci_configure_endpoint_result(xhci, udev,
> + ret = xhci_trace_endpoint_result(xhci, udev,
> &command->status);
No, please stop, this is doing nothing but unneeded code churn, and do
absolutely nothing.
Because you are banned from vger, these patches are not being sent to
the public, so I will not accept them either.
I will not be accepting any patches from you for at least a year, maybe
two, so don't waste your time. Please go work on some other open source
project, if you really want to contribute to the Linux ecosystem, as
long as it is not the kernel.
greg k-h
parent reply other threads:[~2015-06-26 19:09 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1435343148-6854-1-git-send-email-xerofoify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626184805.GA1612@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox