From: Greg KH <gregkh@linuxfoundation.org>
To: Kris Borer <kborer@gmail.com>
Cc: stern@rowland.harvard.edu, balbi@ti.com, pmladek@suse.cz,
antoine.tenart@free-electrons.com, hdegoede@redhat.com,
sergei.shtylyov@cogentembedded.com, rafael.j.wysocki@intel.com,
mickael.maison@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: move assignment out of if condition
Date: Mon, 6 Jul 2015 19:06:35 -0700 [thread overview]
Message-ID: <20150707020635.GA5432@kroah.com> (raw)
In-Reply-To: <1435875839-4680-1-git-send-email-kborer@gmail.com>
On Thu, Jul 02, 2015 at 06:23:59PM -0400, Kris Borer wrote:
> Fix four occurrences of checkpatch.pl error:
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Kris Borer <kborer@gmail.com>
> ---
> drivers/usb/core/hcd.c | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
Again, please use Coccinelle for something like this, otherwise I'm not
going to trust that it is correct :)
thanks,
greg k-h
prev parent reply other threads:[~2015-07-07 4:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 22:23 [PATCH v2] usb: move assignment out of if condition Kris Borer
2015-07-07 2:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707020635.GA5432@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=antoine.tenart@free-electrons.com \
--cc=balbi@ti.com \
--cc=hdegoede@redhat.com \
--cc=kborer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mickael.maison@gmail.com \
--cc=pmladek@suse.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox