public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: "Fredrik Markström" <fredrik.markstrom@gmail.com>,
	mingo@redhat.com, linux-kernel@vger.kernel.org,
	"Rik van Riel" <riel@redhat.com>, "Jason Low" <jason.low2@hp.com>
Subject: Re: [PATCH 1/1] cputime: Make the reported utime+stime correspond to the actual runtime.
Date: Tue, 7 Jul 2015 10:09:13 +0200	[thread overview]
Message-ID: <20150707080913.GT18673@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150707075954.GN3644@twins.programming.kicks-ass.net>

On Tue, Jul 07, 2015 at 09:59:54AM +0200, Peter Zijlstra wrote:
> > > +	/*
> > > +	 * Make sure stime doesn't go backwards; this preserves monotonicity
> > > +	 * for utime because rtime is monotonic.
> > > +	 *
> > > +	 *  utime_i+1 = rtime_i+1 - stime_i
> > > +	 *            = rtime_i+1 - (rtime_i - stime_i)
> > > +	 *            = (rtime_i+1 - rtime_i) + stime_i
> > > +	 *            >= stime_i
> > > +	 */

Argh, just noticed I messed that up, it should read:

+       /*
+        * Make sure stime doesn't go backwards; this preserves monotonicity
+        * for utime because rtime is monotonic.
+        *
+        *  utime_i+1 = rtime_i+1 - stime_i
+        *            = rtime_i+1 - (rtime_i - utime_i)
+        *            = (rtime_i+1 - rtime_i) + utime_i
+        *            >= utime_i
+        */

I got some [us] confusion. Typing is hard.

So we compute: utime = rtime - stime, which we'll denote as:

	utime_i+1 = rtime_i+1 - stime_i

since: stime_i + utime_i = rtime_i, we can write: stime_i = rtime_i -
utime_i and substitute in the above:

		 = rtime_i+1 - (rtime_i - utime_i)

Rearrange terms:

		= (rtime_i+1 - rtime_i) + utime_i

And since we have: rtime_i+1 >= rtime_i, which we can write like:
rtime_i+1 - rtime_i >= 0, substitution gives:

		>= utime_i

And we've proven that the new utime must be equal or greater than the
previous utime, because rtime is monotonic.

  reply	other threads:[~2015-07-07  8:09 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12  8:55 [PATCH 0/1] cputime: Make the reported utime+stime correspond to the actual runtime Fredrik Markstrom
2015-06-12  8:55 ` [PATCH 1/1] " Fredrik Markstrom
2015-06-12 10:16   ` Peter Zijlstra
2015-06-12 11:01     ` Peter Zijlstra
2015-06-15 15:34       ` Fredrik Markström
2015-06-16 14:35         ` Fredrik Markström
2015-06-29 14:58         ` Peter Zijlstra
2015-06-29 15:28           ` Fredrik Markström
2015-06-29 18:54             ` Jason Low
2015-06-29 19:08               ` Fredrik Markström
2015-06-29 22:11                 ` Jason Low
2015-06-30  9:30             ` Peter Zijlstra
2015-06-30 11:50               ` Fredrik Markström
2015-06-30 12:18                 ` Peter Zijlstra
2015-06-30 18:30                   ` Fredrik Markström
2015-07-02 12:11                     ` Peter Zijlstra
2015-07-02 13:07                       ` Peter Zijlstra
2015-07-07  0:51                         ` Frederic Weisbecker
2015-07-07  7:59                           ` Peter Zijlstra
2015-07-07  8:09                             ` Peter Zijlstra [this message]
2015-07-07 12:10                               ` Fredrik Markström
2015-07-07 15:37                                 ` Peter Zijlstra
2015-07-07 13:34                               ` Frederic Weisbecker
2015-07-07 15:34                                 ` Peter Zijlstra
2015-07-07 16:26                                   ` Frederic Weisbecker
2015-06-13 11:17     ` Fredrik Markström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150707080913.GT18673@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=fredrik.markstrom@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jason.low2@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox