[pinctrl:devel 30/37] drivers/pinctrl/pinconf.c:205:6: sparse: symbol 'pinconf_show_config' was not declared. Should it be static?

[pinctrl:devel 30/37] drivers/pinctrl/pinconf.c:205:6: sparse: symbol 'pinconf_show_config' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
head:   16c06171faa4ad430393ca896fc62eb9e2e6dd40
commit: d96310aeddc692cf1f06861cf722c4843e0a3f28 [30/37] pinctrl: pinconf: Fix display of configs
reproduce:
  # apt-get install sparse
  git checkout d96310aeddc692cf1f06861cf722c4843e0a3f28
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/pinctrl/pinconf.c:205:6: sparse: symbol 'pinconf_show_config' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[PATCH pinctrl] pinctrl: pinconf: pinconf_show_config() can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 pinconf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index cbf26a6..078e58d 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -202,7 +202,7 @@ int pinconf_apply_setting(struct pinctrl_setting const *setting)
 
 #ifdef CONFIG_DEBUG_FS
 
-void pinconf_show_config(struct seq_file *s, struct pinctrl_dev *pctldev,
+static void pinconf_show_config(struct seq_file *s, struct pinctrl_dev *pctldev,
 		      unsigned long *configs, unsigned num_configs)
 {
 	const struct pinconf_ops *confops;

Re: [PATCH pinctrl] pinctrl: pinconf: pinconf_show_config() can be static

[Linus Walleij]

On Fri, Jul 17, 2015 at 3:37 PM, kbuild test robot
<fengguang.wu@intel.com> wrote:

> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Patch applied.

Yours,
Linus Walleij