From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kris Borer <kborer@gmail.com>
Cc: gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
hdegoede@redhat.com, chasemetzger15@gmail.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: devio: remove assignment from if condition
Date: Mon, 3 Aug 2015 23:23:47 +0300 [thread overview]
Message-ID: <20150803202347.GX5096@mwanda> (raw)
In-Reply-To: <1438621706-3487-1-git-send-email-kborer@gmail.com>
On Mon, Aug 03, 2015 at 01:08:26PM -0400, Kris Borer wrote:
> else
> + switch (ctl->ioctl_code) {
This else statement isn't indented. It looks weird and it will cause
static checker warnings (hopefully).
Maybe leave that one out and send the rest. Do complicated one in a
different patch.
regards,
dan carpenter
prev parent reply other threads:[~2015-08-03 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 17:08 [PATCH] usb: devio: remove assignment from if condition Kris Borer
2015-08-03 20:23 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803202347.GX5096@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chasemetzger15@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=kborer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox