[PATCH] Input: axp20x-pek: Add module alias

[PATCH] Input: axp20x-pek: Add module alias

[Chen-Yu Tsai]

Add a proper module alias so the driver can be autoloaded when the
parent axp20x mfd driver registers its cells.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/input/misc/axp20x-pek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/misc/axp20x-pek.c b/drivers/input/misc/axp20x-pek.c
index 10e140af5aac..1ac898db303a 100644
--- a/drivers/input/misc/axp20x-pek.c
+++ b/drivers/input/misc/axp20x-pek.c
@@ -292,3 +292,4 @@ module_platform_driver(axp20x_pek_driver);
 MODULE_DESCRIPTION("axp20x Power Button");
 MODULE_AUTHOR("Carlo Caione <carlo@caione.org>");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:axp20x-pek");
-- 
2.5.0

Re: [linux-sunxi] [PATCH] Input: axp20x-pek: Add module alias

[Carlo Caione]

On Mon, Aug 3, 2015 at 9:48 AM, Chen-Yu Tsai <wens@csie.org> wrote:
> Add a proper module alias so the driver can be autoloaded when the
> parent axp20x mfd driver registers its cells.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Acked-by: Carlo Caione <carlo@caione.org>

Thanks,

-- 
Carlo Caione

Re: [linux-sunxi] [PATCH] Input: axp20x-pek: Add module alias

[Dmitry Torokhov]

On Mon, Aug 03, 2015 at 09:56:09AM +0200, Carlo Caione wrote:
> On Mon, Aug 3, 2015 at 9:48 AM, Chen-Yu Tsai <wens@csie.org> wrote:
> > Add a proper module alias so the driver can be autoloaded when the
> > parent axp20x mfd driver registers its cells.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> 
> Acked-by: Carlo Caione <carlo@caione.org>

Applied, thank you.

-- 
Dmitry

Re: [PATCH] Input: axp20x-pek: Add module alias

[Paul Bolle]

On ma, 2015-08-03 at 15:48 +0800, Chen-Yu Tsai wrote:
> Add a proper module alias so the driver can be autoloaded when the
> parent axp20x mfd driver registers its cells.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

> --- a/drivers/input/misc/axp20x-pek.c
> +++ b/drivers/input/misc/axp20x-pek.c

> +MODULE_ALIAS("platform:axp20x-pek");

Should this eventually go into stable?

The AXP20x Power Enable Key driver was added in v4.0, so this patch
could currently be relevant for the v4.1.y tree. (In that tree a "parent
MFD driver" appears to be present too.)


Paul Bolle

Re: [linux-sunxi] Re: [PATCH] Input: axp20x-pek: Add module alias

[Chen-Yu Tsai]

On Tue, Aug 4, 2015 at 4:42 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On ma, 2015-08-03 at 15:48 +0800, Chen-Yu Tsai wrote:
>> Add a proper module alias so the driver can be autoloaded when the
>> parent axp20x mfd driver registers its cells.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
>> --- a/drivers/input/misc/axp20x-pek.c
>> +++ b/drivers/input/misc/axp20x-pek.c
>
>> +MODULE_ALIAS("platform:axp20x-pek");
>
> Should this eventually go into stable?
>
> The AXP20x Power Enable Key driver was added in v4.0, so this patch
> could currently be relevant for the v4.1.y tree. (In that tree a "parent
> MFD driver" appears to be present too.)

(Since I forgot to add the stable tag,) I can submit it for inclusion
into stable after it's merged into Linus' tree.

ChenYu

Re: [linux-sunxi] Re: [PATCH] Input: axp20x-pek: Add module alias

[Dmitry Torokhov]

On Tue, Aug 04, 2015 at 05:04:55PM +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 4, 2015 at 4:42 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> > On ma, 2015-08-03 at 15:48 +0800, Chen-Yu Tsai wrote:
> >> Add a proper module alias so the driver can be autoloaded when the
> >> parent axp20x mfd driver registers its cells.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >
> >> --- a/drivers/input/misc/axp20x-pek.c
> >> +++ b/drivers/input/misc/axp20x-pek.c
> >
> >> +MODULE_ALIAS("platform:axp20x-pek");
> >
> > Should this eventually go into stable?
> >
> > The AXP20x Power Enable Key driver was added in v4.0, so this patch
> > could currently be relevant for the v4.1.y tree. (In that tree a "parent
> > MFD driver" appears to be present too.)
> 
> (Since I forgot to add the stable tag,) I can submit it for inclusion
> into stable after it's merged into Linus' tree.

OTOH do we have many general users needing this driver as a
automatically loaded module? If not that many then it is OK to just
merge it in mainline and skip stable.

Thanks.

-- 
Dmitry

Re: [linux-sunxi] Re: [PATCH] Input: axp20x-pek: Add module alias

[Chen-Yu Tsai]

On Wed, Aug 5, 2015 at 1:46 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Tue, Aug 04, 2015 at 05:04:55PM +0800, Chen-Yu Tsai wrote:
>> On Tue, Aug 4, 2015 at 4:42 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
>> > On ma, 2015-08-03 at 15:48 +0800, Chen-Yu Tsai wrote:
>> >> Add a proper module alias so the driver can be autoloaded when the
>> >> parent axp20x mfd driver registers its cells.
>> >>
>> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> >
>> >> --- a/drivers/input/misc/axp20x-pek.c
>> >> +++ b/drivers/input/misc/axp20x-pek.c
>> >
>> >> +MODULE_ALIAS("platform:axp20x-pek");
>> >
>> > Should this eventually go into stable?
>> >
>> > The AXP20x Power Enable Key driver was added in v4.0, so this patch
>> > could currently be relevant for the v4.1.y tree. (In that tree a "parent
>> > MFD driver" appears to be present too.)
>>
>> (Since I forgot to add the stable tag,) I can submit it for inclusion
>> into stable after it's merged into Linus' tree.
>
> OTOH do we have many general users needing this driver as a
> automatically loaded module? If not that many then it is OK to just
> merge it in mainline and skip stable.

This is a driver for the power button found on most sunxi devices.
I assume distros would build this as a module, and most normal users
would want the power button to work out of the box.


ChenYu