* [PATCH V3 0/1] zram: Remove useless check @ 2015-08-07 18:06 Salah Triki 2015-08-07 18:06 ` [PATCH V3 1/1] " Salah Triki 0 siblings, 1 reply; 3+ messages in thread From: Salah Triki @ 2015-08-07 18:06 UTC (permalink / raw) To: minchan, ngupta, sergey.senozhatsky.work; +Cc: salah.triki, linux-kernel The previous versions of this patch contain spelling errors and cryptic messages, please ignore them. The patch removes the check of the return value of lzo1x_1_compress, since it returns always LZO_E_OK. Salah Triki (1): zram: Remove useless check drivers/block/zram/zcomp_lzo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH V3 1/1] zram: Remove useless check 2015-08-07 18:06 [PATCH V3 0/1] zram: Remove useless check Salah Triki @ 2015-08-07 18:06 ` Salah Triki 2015-08-10 0:02 ` Sergey Senozhatsky 0 siblings, 1 reply; 3+ messages in thread From: Salah Triki @ 2015-08-07 18:06 UTC (permalink / raw) To: minchan, ngupta, sergey.senozhatsky.work; +Cc: salah.triki, linux-kernel lzo1x_1_compress always returns LZO_E_OK that is equal to 0. Thus, the check of the return value is useless. Signed-off-by: Salah Triki <salah.triki@acm.org> --- drivers/block/zram/zcomp_lzo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/zram/zcomp_lzo.c b/drivers/block/zram/zcomp_lzo.c index da1bc47..3cf30c9 100644 --- a/drivers/block/zram/zcomp_lzo.c +++ b/drivers/block/zram/zcomp_lzo.c @@ -26,8 +26,7 @@ static void lzo_destroy(void *private) static int lzo_compress(const unsigned char *src, unsigned char *dst, size_t *dst_len, void *private) { - int ret = lzo1x_1_compress(src, PAGE_SIZE, dst, dst_len, private); - return ret == LZO_E_OK ? 0 : ret; + return lzo1x_1_compress(src, PAGE_SIZE, dst, dst_len, private); } static int lzo_decompress(const unsigned char *src, size_t src_len, -- 1.9.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V3 1/1] zram: Remove useless check 2015-08-07 18:06 ` [PATCH V3 1/1] " Salah Triki @ 2015-08-10 0:02 ` Sergey Senozhatsky 0 siblings, 0 replies; 3+ messages in thread From: Sergey Senozhatsky @ 2015-08-10 0:02 UTC (permalink / raw) To: Salah Triki; +Cc: minchan, ngupta, sergey.senozhatsky.work, linux-kernel On (08/07/15 19:06), Salah Triki wrote: > Date: Fri, 7 Aug 2015 19:06:42 +0100 > From: Salah Triki <salah.triki@acm.org> > To: minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com > Cc: salah.triki@acm.org, linux-kernel@vger.kernel.org > Subject: [PATCH V3 1/1] zram: Remove useless check > X-Mailer: git-send-email 1.9.1 > > lzo1x_1_compress always returns LZO_E_OK that is equal to 0. Thus, the > check of the return value is useless. > > Signed-off-by: Salah Triki <salah.triki@acm.org> > --- > drivers/block/zram/zcomp_lzo.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/block/zram/zcomp_lzo.c b/drivers/block/zram/zcomp_lzo.c > index da1bc47..3cf30c9 100644 > --- a/drivers/block/zram/zcomp_lzo.c > +++ b/drivers/block/zram/zcomp_lzo.c > @@ -26,8 +26,7 @@ static void lzo_destroy(void *private) > static int lzo_compress(const unsigned char *src, unsigned char *dst, > size_t *dst_len, void *private) > { > - int ret = lzo1x_1_compress(src, PAGE_SIZE, dst, dst_len, private); > - return ret == LZO_E_OK ? 0 : ret; > + return lzo1x_1_compress(src, PAGE_SIZE, dst, dst_len, private); > } NACK. it may change someday, we don't control it. the check must stay. -ss ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-10 0:01 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-08-07 18:06 [PATCH V3 0/1] zram: Remove useless check Salah Triki 2015-08-07 18:06 ` [PATCH V3 1/1] " Salah Triki 2015-08-10 0:02 ` Sergey Senozhatsky
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox