* [xen-tip:linux-next 18/23] drivers/xen/sys-hypervisor.c:380:17: sparse: symbol 'pmu_modes' was not declared. Should it be static?
@ 2015-08-11 11:58 kbuild test robot
2015-08-11 11:58 ` [PATCH xen-tip] xen/PMU: pmu_modes[] can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-08-11 11:58 UTC (permalink / raw)
To: Boris Ostrovsky
Cc: kbuild-all, David Vrabel, Konrad Rzeszutek Wilk, xen-devel,
linux-kernel
tree: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip linux-next
head: 0d26d72cab825a0227c8d8e0e42161125b3116fd
commit: 3ad90fe1671a12522e3360aa4c39094360a10b38 [18/23] xen/PMU: Sysfs interface for setting Xen PMU mode
reproduce:
# apt-get install sparse
git checkout 3ad90fe1671a12522e3360aa4c39094360a10b38
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/xen/sys-hypervisor.c:380:17: sparse: symbol 'pmu_modes' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH xen-tip] xen/PMU: pmu_modes[] can be static
2015-08-11 11:58 [xen-tip:linux-next 18/23] drivers/xen/sys-hypervisor.c:380:17: sparse: symbol 'pmu_modes' was not declared. Should it be static? kbuild test robot
@ 2015-08-11 11:58 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-08-11 11:58 UTC (permalink / raw)
To: Boris Ostrovsky
Cc: kbuild-all, David Vrabel, Konrad Rzeszutek Wilk, xen-devel,
linux-kernel
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
sys-hypervisor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
index 0907275..b5a7342 100644
--- a/drivers/xen/sys-hypervisor.c
+++ b/drivers/xen/sys-hypervisor.c
@@ -377,7 +377,7 @@ struct pmu_mode {
uint32_t mode;
};
-struct pmu_mode pmu_modes[] = {
+static struct pmu_mode pmu_modes[] = {
{"off", XENPMU_MODE_OFF},
{"self", XENPMU_MODE_SELF},
{"hv", XENPMU_MODE_HV},
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-11 11:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-11 11:58 [xen-tip:linux-next 18/23] drivers/xen/sys-hypervisor.c:380:17: sparse: symbol 'pmu_modes' was not declared. Should it be static? kbuild test robot
2015-08-11 11:58 ` [PATCH xen-tip] xen/PMU: pmu_modes[] can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox