public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kmod: correct documentation of return status of request_module
@ 2015-08-12  4:16 NeilBrown
  0 siblings, 0 replies; only message in thread
From: NeilBrown @ 2015-08-12  4:16 UTC (permalink / raw)
  To: Andrew Morton, Oleg Nesterov; +Cc: Goldwyn Rodrigues, lkml



if request_module() successfully runs modprobe, but modprobe
exits with a non-zero status, then the return value from
request_module() will be that (positive) error status.
So the return from request_module can be:
 negative errno
 zero for success
 positive exit code.

Signed-off-by: NeilBrown <neilb@suse.com>
Cc: Goldwyn Rodrigues <rgoldwyn@suse.de>

diff --git a/kernel/kmod.c b/kernel/kmod.c
index 2777f40a9c7b..1734ba61ff23 100644
--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -114,10 +114,11 @@ out:
  * @...: arguments as specified in the format string
  *
  * Load a module using the user mode module loader. The function returns
- * zero on success or a negative errno code on failure. Note that a
- * successful module load does not mean the module did not then unload
- * and exit on an error of its own. Callers must check that the service
- * they requested is now available not blindly invoke it.
+ * zero on success or a negative errno code or positive exit code from
+ * "modprobe" on failure. Note that a successful module load does not mean
+ * the module did not then unload and exit on an error of its own. Callers
+ * must check that the service they requested is now available not blindly
+ * invoke it.
  *
  * If module auto-loading support is disabled then this function
  * becomes a no-operation.

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-08-12  4:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-12  4:16 [PATCH] kmod: correct documentation of return status of request_module NeilBrown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox