From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] staging: most: NULL comparison style
Date: Wed, 19 Aug 2015 15:30:21 +0530 [thread overview]
Message-ID: <20150819100021.GA9297@sudip-pc> (raw)
In-Reply-To: <CAOMZO5CW2EwT=FVJvGrTnM7OHPs2Rg5n29eAU+QYL408yDGkyg@mail.gmail.com>
On Tue, Aug 18, 2015 at 01:31:00PM -0300, Fabio Estevam wrote:
> On Tue, Aug 18, 2015 at 12:18 PM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > According to the kernel coding style the NULL check should not be
> > written as [variable] == NULL or [variable] != NULL.
>
> It seems this not documented in Documentation/CodingStyle .
Yes, it is not in the CodingStyle file. But mostly it is the convention
that is followed. And in CodingStyle file if you see the "The rationale
for using gotos is:" section, you will see in the example function the
test is done like: if (!buffer).
Anyways, frankly speaking I know commit message is bad but I could not
think of anything else other than the one I wrote. Any ideas please...
regards
sudip
next prev parent reply other threads:[~2015-08-19 10:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 15:18 [PATCH 1/9] staging: most: NULL comparison style Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 2/9] staging: most: bool " Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 3/9] staging: most: remove multiple blank line Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 4/9] staging: most: out of memory error Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 5/9] staging: most: remove unused functions Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 6/9] staging: most: make functions static Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 7/9] staging: most: use NULL pointer Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 8/9] staging: most: remove unused variable Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 9/9] staging: most: fix Makefile Sudip Mukherjee
2015-08-18 16:31 ` [PATCH 1/9] staging: most: NULL comparison style Fabio Estevam
2015-08-19 10:00 ` Sudip Mukherjee [this message]
2015-08-19 14:51 ` Frans Klaver
2015-08-24 13:49 ` [PATCH v2] " Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819100021.GA9297@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox