From: Vinod Koul <vinod.koul@intel.com>
To: Han Xu <b45815@freescale.com>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] dmaengine: mxs: support i.MX7D and deep sleep mode
Date: Wed, 19 Aug 2015 22:18:16 +0530 [thread overview]
Message-ID: <20150819164816.GI13546@localhost> (raw)
In-Reply-To: <1438105753-22146-1-git-send-email-b45815@freescale.com>
On Tue, Jul 28, 2015 at 12:49:13PM -0500, Han Xu wrote:
> From: Huang Shijie <b32955@freescale.com>
>
> The patch support i.MX7D platform by adding extra DMA clock.
>
> Deep Sleep Mode(dsm) turns off the power for APBH DMA module, add
> suspend/resume function and re-init the APBH DMA during resume.
I have only 2/6, whats going on?
> +static int mxs_dma_pm_suspend(struct device *dev)
> +{
> + /*
> + * We do not save any registers here, since the gpmi will release its
> + * DMA channel.
> + */
> + return 0;
> +}
Why do we need the empty fn?
--
~Vinod
next prev parent reply other threads:[~2015-08-19 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 17:49 [PATCH 2/6] dmaengine: mxs: support i.MX7D and deep sleep mode Han Xu
2015-08-19 16:48 ` Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-28 19:10 Han Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819164816.GI13546@localhost \
--to=vinod.koul@intel.com \
--cc=b45815@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox