From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 09/18] mfd: cros_ec: spi: Add OF match table
Date: Mon, 24 Aug 2015 15:00:19 +0100 [thread overview]
Message-ID: <20150824140019.GL3237@x1> (raw)
In-Reply-To: <1440054451-1223-10-git-send-email-javier@osg.samsung.com>
On Thu, 20 Aug 2015, Javier Martinez Canillas wrote:
> The Documentation/devicetree/bindings/mfd/cros-ec.txt DT binding doc lists
> "google,cros-ec-spi" as a compatible string but the corresponding driver
> does not have an OF match table. Add the table to the driver so the SPI
> core can do an OF style match.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/mfd/cros_ec_spi.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Applied, thanks.
> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
> index 16f228dc243f..30a296b4e748 100644
> --- a/drivers/mfd/cros_ec_spi.c
> +++ b/drivers/mfd/cros_ec_spi.c
> @@ -701,6 +701,12 @@ static int cros_ec_spi_resume(struct device *dev)
> static SIMPLE_DEV_PM_OPS(cros_ec_spi_pm_ops, cros_ec_spi_suspend,
> cros_ec_spi_resume);
>
> +static const struct of_device_id cros_ec_spi_of_match[] = {
> + { .compatible = "google,cros-ec-spi", },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, cros_ec_spi_of_match);
> +
> static const struct spi_device_id cros_ec_spi_id[] = {
> { "cros-ec-spi", 0 },
> { }
> @@ -710,6 +716,7 @@ MODULE_DEVICE_TABLE(spi, cros_ec_spi_id);
> static struct spi_driver cros_ec_driver_spi = {
> .driver = {
> .name = "cros-ec-spi",
> + .of_match_table = of_match_ptr(cros_ec_spi_of_match),
> .owner = THIS_MODULE,
> .pm = &cros_ec_spi_pm_ops,
> },
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-08-24 14:00 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 7:07 [PATCH 00/18] Export SPI and OF module aliases in missing drivers Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 01/18] iio: Export SPI module alias information " Javier Martinez Canillas
2015-08-20 15:49 ` Lars-Peter Clausen
2015-08-22 18:08 ` Jonathan Cameron
2015-08-20 7:07 ` [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information Javier Martinez Canillas
2015-08-22 17:59 ` Jonathan Cameron
2015-08-31 23:09 ` Javier Martinez Canillas
2015-09-05 16:31 ` Jonathan Cameron
2015-09-05 23:34 ` Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 03/18] mtd: dataflash: Export OF " Javier Martinez Canillas
2015-08-20 21:54 ` Brian Norris
2015-08-20 22:13 ` Javier Martinez Canillas
2015-08-20 22:34 ` Brian Norris
2015-08-20 22:57 ` Javier Martinez Canillas
2015-08-21 22:47 ` Brian Norris
2015-08-22 0:26 ` Javier Martinez Canillas
2015-08-22 1:05 ` Brian Norris
2015-08-22 1:10 ` Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 04/18] OMAPDSS: panel-sony-acx565akm: " Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 05/18] mmc: mmc_spi: " Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 06/18] staging: mt29f_spinand: " Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 07/18] net: ks8851: " Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 08/18] [media] s5c73m3: " Javier Martinez Canillas
2015-09-11 1:19 ` Javier Martinez Canillas
2015-09-11 9:37 ` Andrzej Hajda
2015-09-11 10:10 ` Andrzej Hajda
2015-09-11 10:33 ` Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 09/18] mfd: cros_ec: spi: Add OF match table Javier Martinez Canillas
2015-08-24 14:00 ` Lee Jones [this message]
2015-08-20 7:07 ` [PATCH 10/18] iio: dac: ad7303: " Javier Martinez Canillas
2015-08-20 15:49 ` Lars-Peter Clausen
2015-08-22 18:06 ` Jonathan Cameron
2015-08-20 7:07 ` [PATCH 11/18] iio: adc: max1027: Set struct spi_driver .of_match_table Javier Martinez Canillas
2015-08-22 18:00 ` Jonathan Cameron
2015-08-20 7:07 ` [PATCH 12/18] mfd: stmpe: Add OF match table Javier Martinez Canillas
2015-08-24 13:59 ` Lee Jones
2015-08-20 7:07 ` [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table Javier Martinez Canillas
2015-08-20 20:09 ` Michael Welling
2015-08-20 22:02 ` Javier Martinez Canillas
2015-08-20 22:29 ` Michael Welling
2015-08-20 22:48 ` Javier Martinez Canillas
2015-08-20 23:53 ` Michael Welling
2015-08-22 18:09 ` Jonathan Cameron
2015-08-22 17:48 ` Jonathan Cameron
2015-08-23 22:10 ` Rob Herring
2015-08-24 7:19 ` Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 14/18] iio: as3935: Add OF match table Javier Martinez Canillas
2015-08-22 18:02 ` Jonathan Cameron
2015-08-20 7:07 ` [PATCH 15/18] iio: adc128s052: " Javier Martinez Canillas
2015-08-22 18:03 ` Jonathan Cameron
2015-08-20 7:07 ` [PATCH 16/18] iio: frequency: adf4350: " Javier Martinez Canillas
2015-08-20 15:49 ` Lars-Peter Clausen
2015-08-22 18:04 ` Jonathan Cameron
2015-08-20 7:07 ` [PATCH 17/18] NFC: trf7970a: " Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 18/18] spi: (RFC, don't apply) report OF style modalias when probing using DT Javier Martinez Canillas
2015-08-20 18:36 ` Mark Brown
2015-08-20 21:08 ` Brian Norris
2015-08-20 21:45 ` Javier Martinez Canillas
2015-08-20 23:25 ` Mark Brown
2015-08-20 23:47 ` Javier Martinez Canillas
2015-08-21 17:29 ` Mark Brown
2015-08-24 8:00 ` Javier Martinez Canillas
2015-08-20 21:11 ` [PATCH 00/18] Export SPI and OF module aliases in missing drivers Brian Norris
2015-08-20 21:50 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150824140019.GL3237@x1 \
--to=lee.jones@linaro.org \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox