From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: David Matlack <dmatlack@google.com>
Cc: Lior Dotan <liodot@gmail.com>,
Christopher Harrer <charrer@alacritech.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: slicoss: remove unused variables
Date: Sat, 5 Sep 2015 13:38:56 +0530 [thread overview]
Message-ID: <20150905080856.GA29370@sudip-pc> (raw)
In-Reply-To: <CALzav=faP5sMU+x=L6YKO=zTBVcEFq+0NN50QhfVaaxaU0e2oQ@mail.gmail.com>
On Fri, Sep 04, 2015 at 11:13:00AM -0700, David Matlack wrote:
> On Fri, Sep 4, 2015 at 6:23 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > These variables were only assigned some values but they were never used.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
<snip>
> > - status = slic_upr_request(adapter, SLIC_UPR_RLSR,
> > - (u32) &pshmem->linkstatus, /* no 4GB wrap guaranteed */
> > - 0, 0, 0);
> > + slic_upr_request(adapter, SLIC_UPR_RLSR,
> > + (u32)&pshmem->linkstatus, /* no 4GB wrap guaranteed */
> > + 0, 0, 0);
>
> Is status safe to ignore?
status can have two value either -ENOMEM or STATUS_PEMDING.
Ideally we should have handled -ENOMEM.
regards
sudip
next prev parent reply other threads:[~2015-09-05 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 13:23 [PATCH] staging: slicoss: remove unused variables Sudip Mukherjee
2015-09-04 18:13 ` David Matlack
2015-09-05 8:08 ` Sudip Mukherjee [this message]
2015-09-09 18:31 ` Greg Kroah-Hartman
2015-09-10 13:22 ` Sudip Mukherjee
2015-09-12 2:51 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150905080856.GA29370@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=charrer@alacritech.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmatlack@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox