From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: spidev: fix possible NULL dereference
Date: Fri, 11 Sep 2015 18:19:45 +0530 [thread overview]
Message-ID: <20150911124945.GA10016@sudip-pc> (raw)
In-Reply-To: <20150911122513.GT12027@sirena.org.uk>
On Fri, Sep 11, 2015 at 01:25:13PM +0100, Mark Brown wrote:
> On Fri, Sep 11, 2015 at 03:11:32PM +0300, Jarkko Nikula wrote:
>
> > Actually this fixes a *real* NULL dereference case but it is not related to
> > normal open/close life cycle of spidev. It requires that spidev is kept open
> > when SPI master is removed.
>
> > spidev->spi is set to NULL in spidev_remove() and it is called before
> > spidev_release() in case master is removed while spidev is in use
>
> > It would be good to update this to commit log, add a tag below and Cc
> > <stable@vger.kernel.org>
>
> > Fixes: 9169051617df ("spi: spidev: Don't mangle max_speed_hz in underlying
> > spi device")
>
> The patch was already applied :(
Applied? But usually I will receive an auto mail from you after applying.
I dont think I have received any.
regards
sudip
next prev parent reply other threads:[~2015-09-11 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 11:18 [PATCH] spi: spidev: fix possible NULL dereference Sudip Mukherjee
2015-09-11 12:11 ` Jarkko Nikula
2015-09-11 12:25 ` Mark Brown
2015-09-11 12:49 ` Sudip Mukherjee [this message]
2015-09-11 14:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911124945.GA10016@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox