From: "Raj, Ashok" <ashok.raj@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
Tony Luck <tony.luck@intel.com>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Patch V1] x86, mce: CPU synchronization for broadcast MCE's is surprised by offline CPUs
Date: Fri, 11 Sep 2015 14:03:03 -0400 [thread overview]
Message-ID: <20150911180302.GA4233@otc-brkl-03.jf.intel.com> (raw)
In-Reply-To: <20150911084636.GB2042@pd.tnic>
Hi Boris
On Fri, Sep 11, 2015 at 10:46:36AM +0200, Borislav Petkov wrote:
>
> One more buffer for MCEs? Why?
>
> We did add the mce_gen_pool thing exactly for logging stuff in atomic
> context. From looking at the code, we probably could get rid of that
> "struct mce_log mcelog" thing too and use only the gen_pool for logging
> MCEs.
I think using gen_pool should be fine. Also seems the notify moved to the
mce_gen_pool_process(), so there should be no notifier calls from the offline
cpu.
Let me take a respin and resend. I should have noticed.. apologies.
>
> We can then get rid of that MCE_LOG_LEN arbitrary 32 records and use
> a nice 2-paged buffer which can be enlarged transparently later, if
> needed.
next prev parent reply other threads:[~2015-09-11 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 0:26 [Patch V1] x86, mce: CPU synchronization for broadcast MCE's is surprised by offline CPUs Ashok Raj
2015-09-11 8:46 ` Borislav Petkov
2015-09-11 18:03 ` Raj, Ashok [this message]
2015-09-11 17:55 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911180302.GA4233@otc-brkl-03.jf.intel.com \
--to=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox