* [PATCH] staging/rtl8192u: remove unused function
@ 2015-09-14 18:00 Nicolas Joseph
2015-09-14 18:25 ` Raphaël Beamonte
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Joseph @ 2015-09-14 18:00 UTC (permalink / raw)
To: Greg Kroah-Hartman, Raphaël Beamonte, Cristina Opriceana,
Luis de Bethencourt, Koray Gulcu, Aya Mahfouz, Nicolas Joseph,
devel, linux-kernel
Remove N_DBPSOfRate used in ComputeTxTime, remove by
commit 742728f97a99 ("staging: rtl8192u: remove unused function.")
Signed-off-by: Nicolas Joseph <nicolas.joseph@homecomputing.fr>
---
drivers/staging/rtl8192u/r8192U_core.c | 44 ----------------------------------
1 file changed, 44 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index b143b36..80a6a4f 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -1227,50 +1227,6 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
return 0;
}
-u16 N_DBPSOfRate(u16 DataRate)
-{
- u16 N_DBPS = 24;
-
- switch (DataRate) {
- case 60:
- N_DBPS = 24;
- break;
-
- case 90:
- N_DBPS = 36;
- break;
-
- case 120:
- N_DBPS = 48;
- break;
-
- case 180:
- N_DBPS = 72;
- break;
-
- case 240:
- N_DBPS = 96;
- break;
-
- case 360:
- N_DBPS = 144;
- break;
-
- case 480:
- N_DBPS = 192;
- break;
-
- case 540:
- N_DBPS = 216;
- break;
-
- default:
- break;
- }
-
- return N_DBPS;
-}
-
short rtl819xU_tx_cmd(struct net_device *dev, struct sk_buff *skb)
{
struct r8192_priv *priv = ieee80211_priv(dev);
--
2.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging/rtl8192u: remove unused function
2015-09-14 18:00 [PATCH] staging/rtl8192u: remove unused function Nicolas Joseph
@ 2015-09-14 18:25 ` Raphaël Beamonte
2015-09-15 9:21 ` Nicolas Joseph
2015-09-15 9:35 ` Nicolas Joseph
0 siblings, 2 replies; 4+ messages in thread
From: Raphaël Beamonte @ 2015-09-14 18:25 UTC (permalink / raw)
To: Nicolas Joseph
Cc: Greg Kroah-Hartman, Cristina Opriceana, Luis de Bethencourt,
Koray Gulcu, Aya Mahfouz, devel, lkml
2015-09-14 14:00 GMT-04:00 Nicolas Joseph <nicolas.joseph@homecomputing.fr>:
> Remove N_DBPSOfRate used in ComputeTxTime, remove by
> commit 742728f97a99 ("staging: rtl8192u: remove unused function.")
>
> Signed-off-by: Nicolas Joseph <nicolas.joseph@homecomputing.fr>
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 44 ----------------------------------
> 1 file changed, 44 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index b143b36..80a6a4f 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -1227,50 +1227,6 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
> return 0;
> }
>
> -u16 N_DBPSOfRate(u16 DataRate)
> -{
> - u16 N_DBPS = 24;
> -
> - switch (DataRate) {
> - case 60:
> - N_DBPS = 24;
> - break;
> -
> - case 90:
> - N_DBPS = 36;
> - break;
> -
> - case 120:
> - N_DBPS = 48;
> - break;
> -
> - case 180:
> - N_DBPS = 72;
> - break;
> -
> - case 240:
> - N_DBPS = 96;
> - break;
> -
> - case 360:
> - N_DBPS = 144;
> - break;
> -
> - case 480:
> - N_DBPS = 192;
> - break;
> -
> - case 540:
> - N_DBPS = 216;
> - break;
> -
> - default:
> - break;
> - }
> -
> - return N_DBPS;
> -}
> -
> short rtl819xU_tx_cmd(struct net_device *dev, struct sk_buff *skb)
> {
> struct r8192_priv *priv = ieee80211_priv(dev);
> --
> 2.5.2
>
Not sure the commit message is really clear. Something like this seems
more clean to me:
"Remove unused function N_DBPSOfRate. This function was only
used by function ComputeTxTime that was removed in a previous
commit."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging/rtl8192u: remove unused function
2015-09-14 18:25 ` Raphaël Beamonte
@ 2015-09-15 9:21 ` Nicolas Joseph
2015-09-15 9:35 ` Nicolas Joseph
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Joseph @ 2015-09-15 9:21 UTC (permalink / raw)
To: Raphaël Beamonte
Cc: Greg Kroah-Hartman, Cristina Opriceana, Luis de Bethencourt,
Koray Gulcu, Aya Mahfouz, devel, lkml
Le 14/09/15 à 14:25, Raphaël Beamonte a écrit :
> Not sure the commit message is really clear. Something like this seems
> more clean to me:
> "Remove unused function N_DBPSOfRate. This function was only
> used by function ComputeTxTime that was removed in a previous
> commit."
Indeed, is more clear. I repost my path with this commit message, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging/rtl8192u: remove unused function
2015-09-14 18:25 ` Raphaël Beamonte
2015-09-15 9:21 ` Nicolas Joseph
@ 2015-09-15 9:35 ` Nicolas Joseph
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Joseph @ 2015-09-15 9:35 UTC (permalink / raw)
To: Greg Kroah-Hartman, Raphaël Beamonte, Cristina Opriceana,
Luis de Bethencourt, Koray Gulcu, Aya Mahfouz, devel,
linux-kernel
Cc: Nicolas Joseph
Remove unused function N_DBPSOfRate. This function was only used by
function ComputeTxTime that was removed in the previous
commit 742728f97a99 ("staging: rtl8192u: remove unused function.")
Signed-off-by: Nicolas Joseph <nicolas.joseph@homecomputing.fr>
---
drivers/staging/rtl8192u/r8192U_core.c | 44 ----------------------------------
1 file changed, 44 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index b143b36..80a6a4f 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -1227,50 +1227,6 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
return 0;
}
-u16 N_DBPSOfRate(u16 DataRate)
-{
- u16 N_DBPS = 24;
-
- switch (DataRate) {
- case 60:
- N_DBPS = 24;
- break;
-
- case 90:
- N_DBPS = 36;
- break;
-
- case 120:
- N_DBPS = 48;
- break;
-
- case 180:
- N_DBPS = 72;
- break;
-
- case 240:
- N_DBPS = 96;
- break;
-
- case 360:
- N_DBPS = 144;
- break;
-
- case 480:
- N_DBPS = 192;
- break;
-
- case 540:
- N_DBPS = 216;
- break;
-
- default:
- break;
- }
-
- return N_DBPS;
-}
-
short rtl819xU_tx_cmd(struct net_device *dev, struct sk_buff *skb)
{
struct r8192_priv *priv = ieee80211_priv(dev);
--
2.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-15 9:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-14 18:00 [PATCH] staging/rtl8192u: remove unused function Nicolas Joseph
2015-09-14 18:25 ` Raphaël Beamonte
2015-09-15 9:21 ` Nicolas Joseph
2015-09-15 9:35 ` Nicolas Joseph
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox