* [patch] ACPI / tables: test the correct variable
@ 2015-09-22 12:29 Dan Carpenter
2015-09-25 0:23 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-09-22 12:29 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Len Brown, linux-acpi, linux-kernel, kernel-janitors
The intent was to test "proc[i].handler" instead of "proc->handler".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index c1ff58d..6c0f079 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -268,7 +268,8 @@ acpi_parse_entries_array(char *id, unsigned long table_size,
for (i = 0; i < proc_num; i++) {
if (entry->type != proc[i].id)
continue;
- if (!proc->handler || proc[i].handler(entry, table_end))
+ if (!proc[i].handler ||
+ proc[i].handler(entry, table_end))
return -EINVAL;
proc->count++;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] ACPI / tables: test the correct variable
2015-09-22 12:29 [patch] ACPI / tables: test the correct variable Dan Carpenter
@ 2015-09-25 0:23 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2015-09-25 0:23 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Len Brown, linux-acpi, linux-kernel, kernel-janitors
On Tuesday, September 22, 2015 03:29:25 PM Dan Carpenter wrote:
> The intent was to test "proc[i].handler" instead of "proc->handler".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index c1ff58d..6c0f079 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -268,7 +268,8 @@ acpi_parse_entries_array(char *id, unsigned long table_size,
> for (i = 0; i < proc_num; i++) {
> if (entry->type != proc[i].id)
> continue;
> - if (!proc->handler || proc[i].handler(entry, table_end))
> + if (!proc[i].handler ||
> + proc[i].handler(entry, table_end))
> return -EINVAL;
>
> proc->count++;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-24 23:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-22 12:29 [patch] ACPI / tables: test the correct variable Dan Carpenter
2015-09-25 0:23 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox