Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

On Thu, Sep 24, 2015 at 12:00:01PM +0300, Dan Carpenter wrote:
> On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote:
> > This is a patch to the rtl871x_mp.h that fixes up following warnings
> > reported by checkpatch.pl :
> > 
> > -Block comments use a trailing */ on a separate line
> > 
> > Signed-off-by: Punit Vara <punitvara@gmail.com>
> > ---
> >  drivers/staging/rtl8712/rtl871x_mp.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/rtl8712/rtl871x_mp.h b/drivers/staging/rtl8712/rtl871x_mp.h
> > index 75893f2..20a4273 100644
> > --- a/drivers/staging/rtl8712/rtl871x_mp.h
> > +++ b/drivers/staging/rtl8712/rtl871x_mp.h
> > @@ -108,7 +108,8 @@ struct mp_priv {
> >  	unsigned char network_macaddr[6];
> >  	/*Testing Flag*/
> >  	u32 mode;/*0 for normal type packet,
> 
> This first line is missing some spaces so the whole comment needs to be
> redone.
> 
> 	u32 mode; /* 0 for normal type packet,
> 		   * 1 for loopback packet (16bytes TXCMD)
> 		   */
If he is modifying the first line then shouldn't it be:
	u32 mode; /* 
		   * 0 for normal type packet,
		   * 1 for loopback packet (16bytes TXCMD)
		   */

regards
sudip