public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alexander Kapshuk <alexander.kapshuk@gmail.com>
Cc: linux-kernel@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] ver_linux: uniform output across various linux distros
Date: Tue, 29 Sep 2015 18:43:15 +0200	[thread overview]
Message-ID: <20150929164315.GA1300@kroah.com> (raw)
In-Reply-To: <CAJ1xhMW0yDZD3p+X5JmL8dNG+jE3voq4AU=etrkHcTK-s9ZJDg@mail.gmail.com>

On Tue, Sep 29, 2015 at 06:36:12PM +0300, Alexander Kapshuk wrote:
> I've reread 'Documentation/SubmittingPatches', and opted for method 1
> to create the patch.
> 
> When you mentioned about the patch changing the formatting, were you
> referring to the formatting of the actual script, or the output the
> script generated? If it's the former, I'm not sure I'm clear on how to
> keep separate the changes made to the code base from the changes in
> the formatting of the new code base introduced by these changes. If
> it's the latter, the overall output generated by the script is mostly
> identical to that generated by the original implementation.
> 
> If the patch below is still off the mark, I apologise for that, and
> would appreciate being pointed out what else needs changing, when you
> have the time. I understand you having more pressing matters to attend
> to.
> 
> Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>

This is the "oddest" changelog comments I've ever seen for a patch, it
doesn't describe what it is doing at all :)

Please fix up, and resend the whole thing correctly, so we can review
that.

thanks,

greg k-h

  reply	other threads:[~2015-09-29 16:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 15:36 [PATCH] ver_linux: uniform output across various linux distros Alexander Kapshuk
2015-09-29 16:43 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-09-29 18:08 Alexander Kapshuk
2015-09-30  7:33 ` Greg KH
2015-09-30  7:43   ` Alexander Kapshuk
2015-09-28 19:42 Alexander Kapshuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150929164315.GA1300@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexander.kapshuk@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox