From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tillmann Heidsieck <theidsieck@leenox.de>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com,
Punit Vara <punitvara@gmail.com>,
stillcompiling@gmail.com, gregkh@linuxfoundation.org,
dogukan.ergun@gmail.com, linux-kernel@vger.kernel.org,
Joe Perches <joe@perches.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision
Date: Wed, 30 Sep 2015 12:34:33 +0300 [thread overview]
Message-ID: <20150930093433.GD7340@mwanda> (raw)
In-Reply-To: <20150929202458.GA4213@themis.lan>
On Tue, Sep 29, 2015 at 10:24:59PM +0200, Tillmann Heidsieck wrote:
> On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote:
> > The primary requirement for moving a driver out of staging is that it use
> > mac80211. No amount of cosmetic fixing will ever make that change for
> > rtl8712u!
>
> As I am pretty sure someone has done something like this before, is
> there a best practice write-up on this? Or a driver that is recommended
> for usage as a template?
That's a good question. The rtl* drivers are basically a dozen copies
of the same code. I think we have had a few escape from staging?
regards,
dan carpenter
next prev parent reply other threads:[~2015-09-30 9:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 16:49 [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision Punit Vara
2015-09-26 17:45 ` Larry Finger
2015-09-26 17:54 ` punit vara
2015-09-26 18:11 ` Joshua Clayton
2015-09-28 8:35 ` Dan Carpenter
2015-09-28 11:18 ` Sudip Mukherjee
2015-09-28 13:46 ` punit vara
2015-09-28 14:56 ` Larry Finger
2015-09-28 15:19 ` Sudip Mukherjee
2015-09-29 20:24 ` Tillmann Heidsieck
2015-09-30 9:34 ` Dan Carpenter [this message]
2015-10-09 14:54 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930093433.GD7340@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=dogukan.ergun@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=punitvara@gmail.com \
--cc=stillcompiling@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=theidsieck@leenox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox