From: Mark Brown <broonie@kernel.org>
To: jon@ringle.org
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Jon Ringle <jringle@gridpoint.com>
Subject: Re: [PATCH 1/2] regmap: Allow installing custom reg_update_bits function
Date: Thu, 1 Oct 2015 10:44:24 +0100 [thread overview]
Message-ID: <20151001094424.GG15635@sirena.org.uk> (raw)
In-Reply-To: <1443681187-29505-1-git-send-email-jon@ringle.org>
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
On Thu, Oct 01, 2015 at 02:33:06AM -0400, jon@ringle.org wrote:
> @@ -2509,6 +2510,10 @@ static int _regmap_update_bits(struct regmap *map, unsigned int reg,
> int ret;
> unsigned int tmp, orig;
>
> + if (map->reg_update_bits)
> + return map->reg_update_bits(map->bus_context, reg, mask, val,
> + change, force_write);
> +
> ret = _regmap_read(map, reg, &orig);
> if (ret != 0)
> return ret;
This completely bypasses and therefore breaks the cache infrastructure.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-01 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 6:33 [PATCH 1/2] regmap: Allow installing custom reg_update_bits function jon
2015-10-01 6:33 ` [PATCH 2/2] net: Microchip encx24j600 driver jon
2015-10-01 6:48 ` kbuild test robot
2015-10-01 7:36 ` kbuild test robot
2015-10-01 7:36 ` [RFC PATCH] net: encx24j600_open() can be static kbuild test robot
2015-10-01 7:40 ` [PATCH 2/2] net: Microchip encx24j600 driver kbuild test robot
2015-10-01 9:44 ` Mark Brown [this message]
2015-10-01 12:29 ` [PATCH 1/2] regmap: Allow installing custom reg_update_bits function Jon Ringle
2015-10-02 17:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001094424.GG15635@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jon@ringle.org \
--cc=jringle@gridpoint.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox