From: kbuild test robot <lkp@intel.com>
To: jon@ringle.org
Cc: kbuild-all@01.org, broonie@kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Jon Ringle <jringle@gridpoint.com>
Subject: Re: [PATCH 2/2] net: Microchip encx24j600 driver
Date: Thu, 1 Oct 2015 15:36:18 +0800 [thread overview]
Message-ID: <201510011559.luZbSEuj%fengguang.wu@intel.com> (raw)
In-Reply-To: <1443681187-29505-2-git-send-email-jon@ringle.org>
[-- Attachment #1: Type: text/plain, Size: 4035 bytes --]
Hi Jon,
[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]
config: x86_64-allmodconfig (attached as .config)
reproduce:
git checkout abb68976e3057f70babddaf71802ed126d0297bc
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:6:0,
from include/linux/kernel.h:13,
from include/linux/delay.h:10,
from drivers/net/ethernet/microchip/encx24j600-regmap.c:13:
drivers/net/ethernet/microchip/encx24j600-regmap.c: In function 'regmap_encx24j600_read':
include/linux/kern_levels.h:4:18: warning: format '%d' expects argument of type 'int', but argument 4 has type 'size_t {aka long unsigned int}' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:10:18: note: in expansion of macro 'KERN_SOH'
#define KERN_ERR KERN_SOH "3" /* error conditions */
^
include/linux/printk.h:252:9: note: in expansion of macro 'KERN_ERR'
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
^
>> drivers/net/ethernet/microchip/encx24j600-regmap.c:310:3: note: in expansion of macro 'pr_err'
pr_err("%s: reg=%02x reg_size=%d\n", __func__, reg, reg_size);
^
include/linux/kern_levels.h:4:18: warning: format '%d' expects argument of type 'int', but argument 4 has type 'size_t {aka long unsigned int}' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:10:18: note: in expansion of macro 'KERN_SOH'
#define KERN_ERR KERN_SOH "3" /* error conditions */
^
include/linux/printk.h:252:9: note: in expansion of macro 'KERN_ERR'
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
^
drivers/net/ethernet/microchip/encx24j600-regmap.c:318:3: note: in expansion of macro 'pr_err'
pr_err("%s: reg=%02x val_size=%d\n", __func__, reg, val_size);
^
sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/microchip/encx24j600.c:775:5: sparse: symbol 'encx24j600_open' was not declared. Should it be static?
>> drivers/net/ethernet/microchip/encx24j600.c:796:5: sparse: symbol 'encx24j600_stop' was not declared. Should it be static?
>> drivers/net/ethernet/microchip/encx24j600.c:897:6: sparse: symbol 'encx24j600_tx_timeout' was not declared. Should it be static?
drivers/net/ethernet/microchip/encx24j600.c:1063:9: sparse: undefined identifier 'SET_ETHTOOL_OPS'
drivers/net/ethernet/microchip/encx24j600.c: In function 'encx24j600_spi_probe':
drivers/net/ethernet/microchip/encx24j600.c:1063:2: error: implicit declaration of function 'SET_ETHTOOL_OPS' [-Werror=implicit-function-declaration]
SET_ETHTOOL_OPS(ndev, &encx24j600_ethtool_ops);
^
cc1: some warnings being treated as errors
Please review and possibly fold the followup patch.
vim +/pr_err +310 drivers/net/ethernet/microchip/encx24j600-regmap.c
294 if (reg > 0xa0)
295 return regmap_encx24j600_spi_write(context, reg, dout, len);
296
297 if (len > 2)
298 return -EINVAL;
299
300 return regmap_encx24j600_sfr_write(context, reg, dout, len);
301 }
302
303 static int regmap_encx24j600_read(void *context,
304 const void *reg_buf, size_t reg_size,
305 void *val, size_t val_size)
306 {
307 u8 reg = *(const u8 *)reg_buf;
308
309 if (reg_size != 1) {
> 310 pr_err("%s: reg=%02x reg_size=%d\n", __func__, reg, reg_size);
311 return -EINVAL;
312 }
313
314 if (reg > 0xa0)
315 return regmap_encx24j600_spi_read(context, reg, val, val_size);
316
317 if (val_size > 2) {
318 pr_err("%s: reg=%02x val_size=%d\n", __func__, reg, val_size);
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 50060 bytes --]
next prev parent reply other threads:[~2015-10-01 7:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 6:33 [PATCH 1/2] regmap: Allow installing custom reg_update_bits function jon
2015-10-01 6:33 ` [PATCH 2/2] net: Microchip encx24j600 driver jon
2015-10-01 6:48 ` kbuild test robot
2015-10-01 7:36 ` kbuild test robot [this message]
2015-10-01 7:36 ` [RFC PATCH] net: encx24j600_open() can be static kbuild test robot
2015-10-01 7:40 ` [PATCH 2/2] net: Microchip encx24j600 driver kbuild test robot
2015-10-01 9:44 ` [PATCH 1/2] regmap: Allow installing custom reg_update_bits function Mark Brown
2015-10-01 12:29 ` Jon Ringle
2015-10-02 17:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201510011559.luZbSEuj%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jon@ringle.org \
--cc=jringle@gridpoint.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox