From: Eric Biggers <ebiggers3@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: Update help for firmware loading options
Date: Sun, 4 Oct 2015 14:24:55 -0500 [thread overview]
Message-ID: <20151004192455.GA8829@zyxyz> (raw)
In-Reply-To: <20151004191416.GB9649@kroah.com>
On Sun, Oct 04, 2015 at 08:14:16PM +0100, Greg KH wrote:
>
> Are you sure? I think this should stay as "Userspace..." as that is
> what it does, right?
>
> Turning it off should only drop the userspace callouts, it shouldn't
> stop the kernel from loading firmware from the filesystem all on its own
> with no help.
As far as I can tell that's not true. With FW_LOADER=n, firmware_class.c is
compiled out and request_firmware() always returns -EINVAL. My patch tries to
make it more clear that FW_LOADER is the "top-level" option which covers all
three firmware loading mechanisms: built-in, directly from the filesystem, and
the user-mode helper.
prev parent reply other threads:[~2015-10-04 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-09 22:01 [PATCH] drivers: Update help for firmware loading options Eric Biggers
2015-10-04 19:14 ` Greg KH
2015-10-04 19:24 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151004192455.GA8829@zyxyz \
--to=ebiggers3@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox