* [PATCH] usb: remove unnecessary CONFIG_PM dependency from USB_OTG
@ 2015-10-05 19:13 Nathan Sullivan
2015-10-05 19:33 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Nathan Sullivan @ 2015-10-05 19:13 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-kernel, balbi, Ben Shelton, Nathan Sullivan
From: Ben Shelton <ben.shelton@ni.com>
The USB gadget support currently depends on power management
(CONFIG_PM) being enabled, but does not actually need it enabled.
Remove this dependency.
Tested on Bay Trail hardware with dwc3 USB.
Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
---
drivers/usb/core/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
index a99c89e..9c5cdf3 100644
--- a/drivers/usb/core/Kconfig
+++ b/drivers/usb/core/Kconfig
@@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
config USB_OTG
bool "OTG support"
- depends on PM
default n
help
The most notable feature of USB OTG is support for a
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: remove unnecessary CONFIG_PM dependency from USB_OTG
2015-10-05 19:13 [PATCH] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Nathan Sullivan
@ 2015-10-05 19:33 ` Felipe Balbi
2015-10-05 21:12 ` Nathan Sullivan
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2015-10-05 19:33 UTC (permalink / raw)
To: Nathan Sullivan, gregkh
Cc: linux-usb, linux-kernel, Ben Shelton, Nathan Sullivan
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
Nathan Sullivan <nathan.sullivan@ni.com> writes:
> From: Ben Shelton <ben.shelton@ni.com>
>
> The USB gadget support currently depends on power management
> (CONFIG_PM) being enabled, but does not actually need it enabled.
> Remove this dependency.
>
> Tested on Bay Trail hardware with dwc3 USB.
>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
> ---
> drivers/usb/core/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index a99c89e..9c5cdf3 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
>
> config USB_OTG
> bool "OTG support"
> - depends on PM
IIRC we had this dependency because OTG needs support USB bus suspend
and afaict, that's only available on PM builds
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: remove unnecessary CONFIG_PM dependency from USB_OTG
2015-10-05 19:33 ` Felipe Balbi
@ 2015-10-05 21:12 ` Nathan Sullivan
0 siblings, 0 replies; 3+ messages in thread
From: Nathan Sullivan @ 2015-10-05 21:12 UTC (permalink / raw)
To: Felipe Balbi; +Cc: gregkh, linux-usb, linux-kernel, Ben Shelton
On Mon, Oct 05, 2015 at 02:33:56PM -0500, Felipe Balbi wrote:
>
> IIRC we had this dependency because OTG needs support USB bus suspend
> and afaict, that's only available on PM builds
>
> --
> balbi
Hmm, our use case is separate device and host controllers on a Bay Trail
system. We don't ever need to suspend the bus, since the roles are fixed.
Also, the system is running RT tasks and we don't want PM on.
Maybe the device-side USB option should be separate from the OTG option? We
really don't want HNP or any of the dual-role features, just support for
gadget drivers and USB device controllers.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-05 21:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-05 19:13 [PATCH] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Nathan Sullivan
2015-10-05 19:33 ` Felipe Balbi
2015-10-05 21:12 ` Nathan Sullivan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox